Repository navigation
[13.x] Fix has() and withCount() on self-referencing one-of-many relations - #62009
Merged
taylorotwell merged 2 commits intoOct 14, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Existence queries on a self-referencing
hasOne()->latestOfMany()orofMany()relation return wrong results without any error. This covershas(),whereHas(),whereRelation(),withCount()anddoesntHave():Eager loading works fine, only the existence queries break. For self relations the inner table is aliased to
laravel_reserved_*, but the one-of-many join is merged before that happens, and its constraints use the already qualified foreign key. So the join compares against the outercommentstable instead of the aliased one.Same approach as #61818 for
HasOneThrough: merge the one-of-many joins after the parent existence query has been built, and qualify the foreign key name in the join constraint so it picks up the alias. For non-self relations the generated SQL is unchanged.