Repository navigation
[13.x] Fix extra attributes skipping casts when incrementing or decrementing a model - #61991
Merged
taylorotwell merged 2 commits intoOct 13, 2026
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The extra attributes passed to
increment(),decrement(),incrementEach()anddecrementEach()on a model are written to the database as they were passed in, without going through casts or mutators:The token is stored as plain text, so it ends up unencrypted in the database and can't be read back. The same goes for other casts and set mutators, like a mutator that lowercases an email: the model holds the mutated value but the column gets the raw one.
The methods already
forceFill()the extra attributes onto the model, so this sends those stored values in the update instead of the raw input, matching whatsave()would write. Keys that aren't attributes, like JSON paths (options->enabled), are still passed through as before.