Repository navigation
[13.x] Don't expand URL templates without URL parameters - #61893
Merged
taylorotwell merged 1 commit intoOct 6, 2026
Merged
taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
Contributor
|
Does this still work? Http::withUrlParameters([
'endpoint' => 'https://laravel.com',
'page' => 'docs',
'version' => '9.x',
'thing' => 'validation',
])->get('{+endpoint}/{page}/{version}/{thing}?where={"status":"open"}'); |
Contributor
Author
|
@shaedrich yes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every URL containing
{goes throughUriTemplate::expand(), even whenwithUrlParameters()was never called. Anything in braces is treated as a template variable and removed:The API gets an empty filter and no error is thrown. Plain Guzzle sends the same URL with the braces encoded.
When URL parameters were added in #45982, it was said that nothing changes if you're not using them. This makes that true by only expanding when parameters are set.