Repository navigation
[13.x] Skip building a query in loadMissing() when no relations are given - #61869
Merged
taylorotwell merged 1 commit intoOct 5, 2026
Merged
Conversation
binaryfire
added a commit
to hypervel/components-backup
that referenced
this pull request
Oct 26, 2026
Apply laravel/framework#61869 (57b3e7d76b). Collection::loadMissing([]) returns the same collection without constructing a model query. The upstream regression rejects query construction. The database suite, formatting and full analysis pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since #56711 (12.27.0),
Eloquent\Collection::loadMissing()builds a query from the first item before looking at the requested relations:Before that change,
loadMissing([])was a no-op. Now it always builds a query builder, even when there is nothing to load.This matters for code that calls
loadMissing()generically. For example, flugger/laravel-responder calls it on every Eloquent collection it transforms. When the collection holds non-model items (such as spatie/laravel-data'sData::collect(Model::all()), which keeps the Eloquent collection type), that now throws:This PR returns early when no relations are given, restoring the pre-12.27 behavior for that case. Calls with relations are unchanged. A unit test asserts that no query is built for
loadMissing([]).