Repository navigation
[13.x] Add validation rule builders for remaining validation rules - #61833
Merged
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
ericmp33
marked this pull request as ready for review
October 2, 2026 16:02
shaedrich
reviewed
Oct 2, 2026
Contributor
There was a problem hiding this comment.
We could probably define a base class for cases like this that would otherwise be duplicated.
Contributor
There was a problem hiding this comment.
We could also probably move this functionality to a base rule
Co-authored-by: Sebastian HÃĪdrich <11225821+shaedrich@users.noreply.github.com>
âĶs/AcceptedIf.php Co-authored-by: Sebastian HÃĪdrich <11225821+shaedrich@users.noreply.github.com>
Co-authored-by: Sebastian HÃĪdrich <11225821+shaedrich@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #56346 and #56405 I tried to introduce validation rule builders to improve IDE support, making validation rules easier to discover and use through IDE autocompletion and navigation, so you don't have to use hardcoded strings if you don't want to. These PRs were submitted last year but eventually closed, with the suggestion that a cleaner approach to validation might be explored in Laravel 13.
Now that some time has passed, I'd like to revisit this idea and submit a new PR targeting Laravel 13, following the same approach I originally proposed, while adapting it to the new version where necessary.
example.mp4