Repository navigation
[13.x] normalize queue in SQS bulk method - #61828
Merged
taylorotwell merged 1 commit intoOct 2, 2026
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
jackbayliss
marked this pull request as ready for review
October 2, 2026 14:38
jackbayliss
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello sir,
I KNOW, YOU HATE ENUMS (and people keep targetting them) you'll have to trust me on this.
Moving from Redis to SQS (mq), I realized that JobQueueing and JobQueued end up with the raw enum, rather than it normalized (like in the other drivers) This is cos other drivers end up using
enqueueUsing, but, rather than rewrite this, I thought lets just normalize at the start.Thanks
(I also have a PR i need to do for all the contracts cos queue::size reports it wont work with enums, but all the drivers allow it 😢 )