Repository navigation
[13.x] Release unique job locks in Queue::fakeFor() - #61824
Merged
taylorotwell merged 2 commits intoOct 2, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Queue::fakeFor()andQueue::fakeExceptFor()swap the original queue manager back when the callback finishes, but they never release the unique locks taken by jobs dispatched inside the callback. The fake never runs those jobs, so the locks stay in the cache untiluniqueForexpires, or forever when it isn't set.So if the same unique job is dispatched again after the callback, it gets skipped:
#58718 fixed this for
Queue::fake()by callingreleaseUniqueJobLocks()when faking again. This PR calls it in thefinallyblock offakeFor()andfakeExceptFor()too.releaseUniqueJobLocks()now returns early when no unique jobs were pushed, so it doesn't resolve the cache when there is nothing to release.