Repository navigation
[13.x] Fix DB::setDefaultConnection() storing enums in the configuration - #61810
Merged
taylorotwell merged 1 commit intoOct 2, 2026
Merged
taylorotwell merged 1 commit into
taylorotwell merged 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DatabaseManager::connection(),purge(),disconnect(),reconnect()andusingConnection()all accept enums, butsetDefaultConnection()stores the given value in the configuration as-is. When it receives an enum, the enum instance is written todatabase.default, and every subsequent query on the default connection fails:This PR normalizes the name using
enum_value(), matching thesetDefaultDriver()methods of the other managers (AuthManager,CacheManager,MailManager,QueueManager,LogManager, etc.), and adds tests for both backed and unit enums.