Repository navigation
[13.x] Fix memoized tagged cache many() returning null for numeric keys - #61780
Merged
taylorotwell merged 1 commit intoSep 29, 2026
Conversation
sajjadhossainshohag
deleted the
fix-memoized-tagged-cache-numeric-keys
branch
September 29, 2026 12:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cache::memo()->tags()->many()returnsnullfor cached values when the keys are integers, such as model ids:The same happens through
get([...])andgetMultiple(), and when some of the keys were already memoized.MemoizedTaggedCache::many()combines the memoized values with the ones it just retrieved usingarray_merge(), which renumbers integer keys.10and20become0and1, so thearray_key_exists()lookup that builds the result misses and falls back to the default.This is the same bug that #57862 fixed for the untagged
MemoizedStore, and the tagged memoized cache from #61593 brought it back. This PR uses+=instead, which keeps the keys. The two arrays never share a key, because only missing keys are retrieved.The tests cover a fresh retrieval, a second memoized retrieval, and a partially memoized one.