Repository navigation
[13.x] Treat dotted keys literally in ArrayStore::touch() - #61777
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArrayStore::touch()usesArr::get()to locate entries, which interprets missing dotted keys as paths into internal storage.After storing an array under
profile,touch('profile.value', 60)returns true and creates a malformed entry, even though that cache key does not exist. Later reads of it emit "Undefined array key" warnings, andtouch('profile.expiresAt', 60), which resolves to a scalar, throwsError: Cannot use a scalar value as an array.This change uses direct array lookup, consistent with
get()andput(), so cache keys are treated literally.