Repository navigation
[13.x] Explicitly enable imagick extension for CI tests - #61756
Merged
Merged
Conversation
Member
|
Tests failing on Windows. |
taylorotwell
marked this pull request as draft
September 28, 2026 14:17
Contributor
Author
|
@taylorotwell Can you do a re-run? |
jnoordsij
force-pushed
the
enable-imagick-ext
branch
from
September 29, 2026 06:40
53ebaea to
6c202c2
Compare
jnoordsij
marked this pull request as ready for review
September 29, 2026 06:47
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted in context of #60005, this PR explicitly enables the
imagickextension for tests, given it is leveraged by various tests. Although I don't see how it should have been enable before, it was, and the skipped test count does not seem impacted by this.In the process I've also deduplicated and cleaned up some extension logic, given that the Linux and Windows lists were somewhat hard to compare. In particular some extensions seemed to be missing from the Windows list for no apparent reason. After this change, some more extension are also installed for Windows, with the skipped test count there reduced. Comparison on
PHP 8.5 - PHPUnit 13.0.3 - prefer-stable - Windows: before "Tests: 15662, Assertions: 45233, Warnings: 3, PHPUnit Notices: 96, Skipped: 667.", after "Tests: 15662, Assertions: 45288, Warnings: 3, PHPUnit Notices: 96, Skipped: 633.".