Repository navigation
[13.x] Display error in queue:restart when worker isn't restartable - #61706
Merged
Merged
Conversation
|
Thanks for submitting a PR! Note that draft PRs are not reviewed. If you would like a review, please mark your pull request as ready for review in the GitHub user interface. Pull requests that are abandoned in draft may be closed due to inactivity. |
Contributor
Author
|
tests freaking cos of stan and testbench, but this is good to review ty |
jackbayliss
marked this pull request as ready for review
September 24, 2026 10:31
binaryfire
added a commit
to hypervel/components
that referenced
this pull request
Oct 25, 2026
Queue::withoutInterruptionPolling() sets Worker::$restartable to false. Queue workers then stop reading the restart signal from the cache, and queue:restart refuses to run (laravel/framework#61706). The outbox relay still read the signal on every loop, costing a cache round trip per iteration and restarting on a signal the queue workers ignore. restartTimestamp() now returns null when restarts are disabled, matching Worker::getTimestampOfLastQueueRestart(). Validation: composer lint:fix, composer analyse and the Queue suite pass. The new test fails without the fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The pause command errors if pausing is disabled, but, the restart command doesnt.
We turn off polling off by default via
Queue::withoutInterruptionPolling, so when someone tries to restart a queue via thequeue:restartcommand it appears like it's worked, but it hasnt.This applies the same logic already used by queue:pause, added a test while I was here I adjusted the exit codes.
Thank you 🙏🏻