Repository navigation
Allow null in docblocks to match existing code - #61679
Merged
Merged
Conversation
The code in this file does set these properties to `null` in some cases. As a result, static analysis tools report errors because the `@var` tags only allowed non-nullable strings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a quick fix of docblock tags that do not match actual code, thus causing static analysis tools to report errors.
There are 3 properties documented as non-nullable strings but that can be set to
nullin some cases:assetRoot,forcedRootandforceScheme.assetRootcan be set tonullin the class constructor, because it defaults tonull:forcedRootcan be set tonullinforceRootUrl()(directly or viauseOrigin()):forceScheme, finally, can be set tonullin theforceScheme()method: