Repository navigation
[13.x] Support LazyCollection values in between clauses - #61678
Merged
taylorotwell merged 1 commit intoSep 22, 2026
Merged
Conversation
vikas-kushwaha-dev
marked this pull request as draft
September 22, 2026 20:24
vikas-kushwaha-dev
marked this pull request as ready for review
September 22, 2026 20:24
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I have encountered a issue where when i pass
LazyCollection::make([100, 200])inwhereBetween()andhavingBetween()of SQL it thows errorError: Cannot use object of type Illuminate\Support\LazyCollection as array.But both functions
whereBetween()andhavingBetween()acceptsiterablebut it is not converting theLazyCollectioninto an indexed array.
Proposed Fix:
elseif ($values instanceof Traversable) { $values = iterator_to_array($values, false); }adding
Traversableto convert it into indexed array.Added Test:
$builder = $this->getBuilder(); $builder->select('*')->from('users')->whereBetween('id', LazyCollection::make([1, 2])); $this->assertSame('select * from "users" where "id" between ? and ?', $builder->toSql()); $this->assertEquals([0 => 1, 1 => 2], $builder->getBindings());