Skip to content

Cherry-pick #613 onto 1.4 branch - #628

Merged
k8s-ci-robot merged 1 commit into
kubernetes:release-1.4from
agau4779:release-1.4
Feb 6, 2019
Merged

k8s-ci-robot merged 1 commit into
kubernetes:release-1.4from
agau4779:release-1.4

Conversation

@agau4779

@agau4779 agau4779 commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

Cherry-pick 2nd commit in #613

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

Hi @agau4779. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2019
@agau4779

agau4779 commented Feb 6, 2019

Copy link
Copy Markdown
Contributor Author

/assign @rramkumar1

@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@agau4779: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

Cherry-pick 2nd commit in #613

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 6, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

@agau4779: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

Details

In response to this:

/assign @rramkumar1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@rramkumar1 rramkumar1 changed the title Cherry-pick #613 Cherry-pick #613 onto 1.4 branch Feb 6, 2019
@rramkumar1

Copy link
Copy Markdown
Contributor

/lgtm
/ok-to-test

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2019
@k8s-ci-robot

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agau4779, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 6, 2019
@k8s-ci-robot
k8s-ci-robot merged commit a7199af into kubernetes:release-1.4 Feb 6, 2019
@agau4779
agau4779 deleted the release-1.4 branch February 6, 2019 21:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants