Skip to content

do not leak LB when ingress class is changed [release-1.4] - #626

Merged
rramkumar1 merged 1 commit into
kubernetes:release-1.4from
agau4779:cherrypick-547
Feb 6, 2019
Merged

do not leak LB when ingress class is changed [release-1.4]#626
rramkumar1 merged 1 commit into
kubernetes:release-1.4from
agau4779:cherrypick-547

Conversation

@agau4779

@agau4779 agau4779 commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

Cherry-picking #547

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Feb 6, 2019
@k8s-ci-robot

k8s-ci-robot commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

Hi @agau4779. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Feb 6, 2019
@agau4779

agau4779 commented Feb 6, 2019

Copy link
Copy Markdown
Contributor Author

/assign @rramkumar1

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 6, 2019
@rramkumar1 rramkumar1 changed the title do not leak LB when ingress class is changed Cherry-picking #547 onto 1.4 branch Feb 6, 2019
@rramkumar1

rramkumar1 commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Feb 6, 2019
@rramkumar1

rramkumar1 commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot

k8s-ci-robot commented Feb 6, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: agau4779, rramkumar1

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Feb 6, 2019
@rramkumar1
rramkumar1 merged commit f757ec5 into kubernetes:release-1.4 Feb 6, 2019
@agau4779
agau4779 deleted the cherrypick-547 branch February 6, 2019 19:55
@rramkumar1 rramkumar1 changed the title Cherry-picking #547 onto 1.4 branch do not leak LB when ingress class is changed [release-1.4] Feb 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MrHohn MrHohn Awaiting requested review from MrHohn
@rramkumar1 rramkumar1 Awaiting requested review from rramkumar1

Assignees

@rramkumar1 rramkumar1

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@agau4779 @k8s-ci-robot @rramkumar1 @agadelshin