Repository navigation
[release-0.20] pod: don't build a new group Workload from terminating pods - #17501
Merged
kubernetes-prow[bot] merged 2 commits intoOct 20, 2026
Conversation
A pod group's Workload is built from its pods, with each PodSet template copied from a pod's spec. A pod that is being deleted but is still bound to a node counts as runnable, so it can be picked. Its spec still holds the earlier admission: nodeName, the flavor's node labels and the TAS hostname nodeSelector. The new Workload then fits only that node, and a multi-node gang can never be admitted. This happens when the group's Workload is deleted and replacement pods arrive while the old pods are still in their grace period. The FinalizeTerminatingPodGroups gate only acted when every pod of the group was terminating, so it missed groups that mix old and new pods. With FinalizeTerminatingPodGroups enabled, building a new group Workload now also leaves out the pods that are being deleted on a node: Kueue removes their finalizer, and they do not count toward the group size, shape the PodSets, own the Workload or get its events. The check is for a non-zero deletionTimestamp, since the bug happens during the grace period, while the timestamp is still in the future. Replacement accounting for an existing Workload is unchanged. Once that Workload exists, the old pods still count as excess for it, and removeExcessPods expected an event for each of them. A pod that is already being deleted and has lost Kueue's finalizer is neither patched nor deleted, so no event came and the group's pods stayed gated until the old pods were gone. removeExcessPods now marks such a pod as observed right away, as finalizePods already does. This part is not gated. Signed-off-by: Hao Zhu <zhuhaoangus@gmail.com>
Load used the first listed pod to represent a pod group, and that pod can be one that is being deleted. Building a new group Workload then switched to a live pod, but only inside that build. The cache lists pods in no fixed order, so other reconciles, and the earlier steps of the same reconcile, could still read a terminating pod. For example, an old pod with another queue-name label could rewrite the queue of the Workload that was built from the live pods. With FinalizeTerminatingPodGroups enabled, Load now picks a pod that is not being deleted whenever the group has one. The switch in dropTerminatingPods is no longer needed and is removed. Signed-off-by: Hao Zhu <zhuhaoangus@gmail.com>
kubernetes-prow
Bot
added
release-note
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
kubernetes-prow
Bot
added
size/XL
Contributor
|
/lgtm |
kubernetes-prow
Bot
added
the
lgtm
|
LGTM label has been added. DetailsGit tree hash: 470a8dbf9727522537c03526b0ab451c884b1f49 |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: k8s-infra-cherrypick-robot, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
kubernetes-prow
Bot
added
the
approved
kubernetes-prow
Bot
merged commit Oct 20, 2026
31b6231
into
kubernetes-sigs:release-0.20
62 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an automated cherry-pick of #17454
/assign mimowo
/kind bug