Repository navigation
[release-0.20] Respect Ray worker replica bounds when calculating PodSet counts - #17366
Conversation
(cherry picked from commit a0394b0)
✅ Deploy Preview for kubernetes-sigs-kueue ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. 🗂️ Base branches to auto review: 1
Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
|
/lgtm |
|
LGTM label has been added. DetailsGit tree hash: d764b97200ce595b2e7f708fa8046019ec6f23bf |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kevin85421, mimowo The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
5adcba9
into
kubernetes-sigs:release-0.20
|
/set-release-note |
|
✅ The release note was updated. |
What type of PR is this?
/kind bug
/area integrations
What this PR does / why we need it?
Cherry-pick of #16884 onto
release-0.20, requested in #16884 (comment).Respect KubeRay worker group
minReplicasandmaxReplicaswhen deriving PodSet counts, including multi-host replicas. When an autoscaler allocation timeout reducesreplicasbelowminReplicas, KubeRay still creates the minimum number of workers; accounting for that minimum prevents the extra workers from remaining scheduling-gated.Useful notes for your reviewer
The original fix applies without conflicts. The partial replica scale-up fixture updates are included.
Validation:
go test ./pkg/controller/jobs/raycluster ./pkg/controller/jobs/rayjob ./pkg/controller/jobs/rayservice.make ci-lint.GOTOOLCHAIN=go1.27.0 make verify(including API lint; rebuilt the API linter with Go 1.27 to match this branch).AI assistance: OpenAI Codex prepared the cherry-pick, resolved branch compatibility conflicts where needed, ran validation, and prepared this PR.
Release note