Skip to content

[release-0.20] Respect Ray worker replica bounds when calculating PodSet counts - #17366

Merged
kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:release-0.20from
kevin85421:codex/cherry-pick-16884-release-0.20
Oct 16, 2026
Merged

kubernetes-prow[bot] merged 1 commit into
kubernetes-sigs:release-0.20from
kevin85421:codex/cherry-pick-16884-release-0.20

Conversation

@kevin85421

@kevin85421 kevin85421 commented Oct 16, 2026 •

Copy link
Copy Markdown
Member

What type of PR is this?

/kind bug
/area integrations

What this PR does / why we need it?

Cherry-pick of #16884 onto release-0.20, requested in #16884 (comment).

Respect KubeRay worker group minReplicas and maxReplicas when deriving PodSet counts, including multi-host replicas. When an autoscaler allocation timeout reduces replicas below minReplicas, KubeRay still creates the minimum number of workers; accounting for that minimum prevents the extra workers from remaining scheduling-gated.

Useful notes for your reviewer

The original fix applies without conflicts. The partial replica scale-up fixture updates are included.

Validation:

  • Passed: go test ./pkg/controller/jobs/raycluster ./pkg/controller/jobs/rayjob ./pkg/controller/jobs/rayservice.
  • Passed: make ci-lint.
  • Passed: partial replica scale-up integration suite with race detection (10 specs).
  • Passed: GOTOOLCHAIN=go1.27.0 make verify (including API lint; rebuilt the API linter with Go 1.27 to match this branch).

AI assistance: OpenAI Codex prepared the cherry-pick, resolved branch compatibility conflicts where needed, ran validation, and prepared this PR.

Release note

RayCluster: Fixed a bug where worker PodSet counts could fall below KubeRay’s minimum replica count, leaving workers scheduling-gated when capacity became available. Kueue now respects worker replica bounds when calculating PodSet counts.

@kubernetes-prow kubernetes-prow Bot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Oct 16, 2026
@kubernetes-prow kubernetes-prow Bot added this to the v0.20 milestone Oct 16, 2026
@kubernetes-prow kubernetes-prow Bot added kind/bug Categorizes issue or PR as related to a bug. area/integrations Workload integrations labels Oct 16, 2026
@netlify

netlify Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit a3847cd
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6ad2631206849e348fc96af2
😎 Deploy Preview https://deploy-preview-17366--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Oct 16, 2026
@coderabbitai

coderabbitai Bot commented Oct 16, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review: 1
  • main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration
  • Configuration used: Repository: kubernetes-sigs/kueue/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 5c0edcd4-3547-42aa-84e1-a44dfedb1b1a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

@kubernetes-prow kubernetes-prow Bot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Oct 16, 2026
@kubernetes-prow
kubernetes-prow Bot requested review from amy and olekzabl October 16, 2026 17:47
@mimowo

mimowo commented Oct 16, 2026

Copy link
Copy Markdown
Contributor

/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Oct 16, 2026
@kubernetes-prow

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: d764b97200ce595b2e7f708fa8046019ec6f23bf

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: kevin85421, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Oct 16, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 5adcba9 into kubernetes-sigs:release-0.20 Oct 16, 2026
62 checks passed
@mbobrovskyi

Copy link
Copy Markdown
Contributor

/set-release-note
RayCluster: Fixed a bug where worker PodSet counts could fall below KubeRay’s minimum replica count, leaving workers scheduling-gated when capacity became available. Kueue now respects worker replica bounds when calculating PodSet counts.

@github-actions

Copy link
Copy Markdown

✅ The release note was updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. area/integrations Workload integrations cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants