Skip to content

KueueViz: Generate a shared Ingress from config - #15863

Merged
kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:mainfrom
HsiuChuanHsu:kueueviz-shared-ingress-from-config
Sep 21, 2026
Merged

kubernetes-prow[bot] merged 3 commits into
kubernetes-sigs:mainfrom
HsiuChuanHsu:kueueviz-shared-ingress-from-config

Conversation

@HsiuChuanHsu

@HsiuChuanHsu HsiuChuanHsu commented Sep 20, 2026 •

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind cleanup

What this PR does / why we need it?

Generate the KueueViz shared Ingress configuration from the configuration directory. Keep the generated configuration usable for installations outside Helm.

Fixes #15669

Useful notes for your reviewer

Release note

KueueViz: Added a generated Ingress manifest for non-Helm installations that serves the dashboard and backend from a single host, routing `/ws`, `/api`, and `/auth` to the backend and `/` to the frontend.

AI summary

Adds a generated single-host KueueViz manifest for non-Helm installations. The manifest routes /ws, /api, and /auth to the backend and / to the frontend. Helm generation now uses the shared Ingress configuration. Documentation includes host, TLS, and migration instructions.

Suggested release note

KueueViz: Added a single-host manifest that serves the dashboard and backend through one path-routed Ingress.

@kubernetes-prow kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Sep 20, 2026
@netlify

netlify Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit 3058826
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6ab06eb7721c6d0008193c48

@kubernetes-prow kubernetes-prow Bot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2026
@kubernetes-prow

Copy link
Copy Markdown

Hi @HsiuChuanHsu. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@kubernetes-prow kubernetes-prow Bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Sep 20, 2026
@coderabbitai

coderabbitai Bot commented Sep 20, 2026 •

Copy link
Copy Markdown

Review Change StackReview Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: kubernetes-sigs/kueue/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: b65e0124-14a8-442c-b654-463364c7e7c6

📥 Commits

Reviewing files that changed from the base of the PR and between 62bfb56 and 3058826.

📒 Files selected for processing (1)
  • config/components/kueueviz/kustomization.yaml

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The PR adds a single-host KueueViz Kustomize manifest with path-based routing. It adds Helm processing for the shared Ingress, preserves separate-host overlays, generates the manifest as an artifact, and updates deployment documentation.

Changes

KueueViz single-host deployment

Layer / File(s) Summary
Single-host manifest and routing
config/components/kueueviz/..., config/kueueviz-single-host/...
Adds one Ingress that routes /ws, /api, and /auth to the backend and / to the frontend. The overlay removes the separate component Ingresses and clears frontend backend URLs.
Helm ingress processing
charts/kueue/templates/kueueviz/ingress.yaml, hack/processing-plan.yaml
Regenerates the Helm Ingress template and adds configurable host, ingress class, TLS, annotations, and conditional rendering for the shared Ingress.
Separate-host overlay compatibility
config/kueueviz/kustomization.yaml, config/kueueviz/remove_shared_ingress.yaml
Removes the shared Ingress from the existing separate-host overlay.
Artifact and deployment documentation
Makefile, site/content/en/docs/tasks/manage/enable_kueueviz.md
Builds kueueviz-single-host.yaml and documents installation, host and TLS changes, migration, and the rewrite-target warning.

Priority: ⬇️ Low

Estimated code review effort: 3 (Moderate) | ~25 minutes

Change: Feature

Suggested reviewers: mbobrovskyi

Sequence Diagram(s)

sequenceDiagram
  participant Browser
  participant KueueVizIngress
  participant KueueVizBackend
  participant KueueVizFrontend
  Browser->>KueueVizIngress: Request /ws, /api, or /auth
  KueueVizIngress->>KueueVizBackend: Route request to port 8080
  Browser->>KueueVizIngress: Request /
  KueueVizIngress->>KueueVizFrontend: Route request to port 8080
  KueueVizFrontend-->>Browser: Use the serving origin for WebSocket configuration
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the primary change: generating a shared KueueViz Ingress from configuration.
Linked Issues check ✅ Passed The PR meets the coding requirements in issue #15669. config/components/kueueviz/ingress.yaml defines kueueviz-ingress with /ws, /api, and /auth routed to kueueviz-backend:8080, and / ro…
Out of Scope Changes check ✅ Passed The changes stay within issue #15669. The single-host overlay, deletion patches for the separate Ingress objects, frontend environment patch, Makefile artifact entry, documentation update, and removal…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR

Comment @coderabbitai help to get the list of available commands.

@HsiuChuanHsu HsiuChuanHsu changed the title Kueueviz shared ingress from config KueueViz: Generate a shared Ingress from config Sep 20, 2026
@tenzen-y

Copy link
Copy Markdown
Member

/ok-to-test

@kubernetes-prow kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Sep 20, 2026

@tenzen-y tenzen-y left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
/lgtm
/approve

@kubernetes-prow kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 21, 2026
@kubernetes-prow

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 7926a464174f254a77f5997a4c5435fb9e6971fa

@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: HsiuChuanHsu, tenzen-y

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 21, 2026
@kubernetes-prow
kubernetes-prow Bot merged commit 182db11 into kubernetes-sigs:main Sep 21, 2026
64 checks passed
@kubernetes-prow kubernetes-prow Bot added this to the v0.20 milestone Sep 21, 2026
@tenzen-y

Copy link
Copy Markdown
Member

IIUC, this is just automation and brings the Helm ingress to the config.

@tenzen-y

Copy link
Copy Markdown
Member

/release-note-edit

KueueViz: Support a single comprehensive Ingress usage for non-Helm installations.

@HsiuChuanHsu

Copy link
Copy Markdown
Contributor Author

IIUC, this is just automation and brings the Helm ingress to the config.

Yes. Thanks for the review.

@HsiuChuanHsu
HsiuChuanHsu deleted the kueueviz-shared-ingress-from-config branch September 21, 2026 21:59
@mbobrovskyi

Copy link
Copy Markdown
Contributor

/release-note-edit

KueueViz: Added a generated Ingress manifest for non-Helm installations that serves the dashboard and backend from a single host, routing `/ws`, `/api`, and `/auth` to the backend and `/` to the frontend.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🧹 Generate KueueViz shared Ingress from config

4 participants