Repository navigation
KueueViz: Generate a shared Ingress from config - #15863
kubernetes-prow[bot] merged 3 commits into
Conversation
✅ Deploy Preview for kubernetes-sigs-kueue canceled.
|
|
Hi @HsiuChuanHsu. Thanks for your PR. I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with Tip We noticed you've done this a few times! Consider joining the org to skip this step and gain Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository: kubernetes-sigs/kueue/.coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughThe PR adds a single-host KueueViz Kustomize manifest with path-based routing. It adds Helm processing for the shared Ingress, preserves separate-host overlays, generates the manifest as an artifact, and updates deployment documentation. ChangesKueueViz single-host deployment
Priority: ⬇️ Low Estimated code review effort: 3 (Moderate) | ~25 minutes Change: Feature Suggested reviewers: Sequence Diagram(s)sequenceDiagram
participant Browser
participant KueueVizIngress
participant KueueVizBackend
participant KueueVizFrontend
Browser->>KueueVizIngress: Request /ws, /api, or /auth
KueueVizIngress->>KueueVizBackend: Route request to port 8080
Browser->>KueueVizIngress: Request /
KueueVizIngress->>KueueVizFrontend: Route request to port 8080
KueueVizFrontend-->>Browser: Use the serving origin for WebSocket configuration
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
/ok-to-test |
|
LGTM label has been added. DetailsGit tree hash: 7926a464174f254a77f5997a4c5435fb9e6971fa |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: HsiuChuanHsu, tenzen-y The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
IIUC, this is just automation and brings the Helm ingress to the config. |
|
/release-note-edit |
Yes. Thanks for the review. |
|
/release-note-edit |
What type of PR is this?
/kind cleanup
What this PR does / why we need it?
Generate the KueueViz shared Ingress configuration from the configuration directory. Keep the generated configuration usable for installations outside Helm.
Fixes #15669
Useful notes for your reviewer
Release note
AI summary
Adds a generated single-host KueueViz manifest for non-Helm installations. The manifest routes
/ws,/api, and/authto the backend and/to the frontend. Helm generation now uses the shared Ingress configuration. Documentation includes host, TLS, and migration instructions.Suggested release note
KueueViz: Added a single-host manifest that serves the dashboard and backend through one path-routed Ingress.