[sohankunkerkar]

Cherry pick of #15279 on release-0.18.

#15279: Resize the StatefulSet workload when scaling up from zero to a different size

For details on the cherry pick process, see the cherry pick requests page.

What type of PR is this?

/kind bug

StatefulSet: Fixed a bug where scaling a StatefulSet to zero and then back up to a different number of replicas left the Workload with the original pod count, causing it to be admitted and charged quota for the wrong number of pods.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	1b05d64
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6aa07aeea3f2100007e6f860

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 90d2fd60-fdc0-4c9f-8b37-812b034379ba

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[Copilot]

🟡 Changes recommended

The new integration test uses new(int32(…)) for replica pointers, which is invalid in this package and will not compile (should use the existing ptr.To[int32](…) pattern).

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Cherry-picks a fix onto release-0.18 to ensure a Kueue-managed StatefulSet’s associated Workload is resized correctly when scaling from 0 replicas back up to a different replica count, preventing re-admission/quota charging with a stale pod count.

Changes:

• Resync Workload.spec.podSets[].count when clearing the “OnHold” state so scale-up from zero is admitted with the correct pod count.
• Add/extend integration coverage around StatefulSet rollout gating behavior and the 0→N resize/re-admission scenario.

File summaries

File	Description
pkg/controller/jobs/statefulset/statefulset_reconciler.go	Resync pod-set counts while clearing OnHold so workloads re-admit at the updated replica count.
test/integration/singlecluster/controller/jobs/statefulset/statefulset_controller_test.go	Adds integration tests for rollout gating behavior and for resizing workload counts when scaling 0→different N.

Review details

Suppressed comments (1)

test/integration/singlecluster/controller/jobs/statefulset/statefulset_controller_test.go:353

• new(int32(5)) is not valid Go syntax in this package; this will not compile. Use the existing ptr.To[int32](...) pattern used elsewhere in this file to set the pointer value.

			createdSTS.Spec.Replicas = new(int32(5))

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mimowo]

/lgtm
/approve
/test pull-kueue-verify-release-0-18

[kubernetes-prow]

LGTM label has been added.

Details

Git tree hash: e62156e0624d876270e5b9986a4cf5b152c495b9

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mimowo,sohankunkerkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment