[sohankunkerkar]

Cherry pick of #15279 on release-0.19.

#15279: Resize the StatefulSet workload when scaling up from zero to a different size

For details on the cherry pick process, see the cherry pick requests page.

What type of PR is this?

/kind bug

StatefulSet: Fixed a bug where scaling a StatefulSet to zero and then back up to a different number of replicas left the Workload with the original pod count, causing it to be admitted and charged quota for the wrong number of pods.

[coderabbitai]

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

🗂️ Base branches to auto review (1)

• main

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: a7654153-8738-4771-ad1f-f9d6a7d6386a

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

• 🔍 Trigger review

---

_{Comment @coderabbitai help to get the list of available commands.}

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name	Link
🔨 Latest commit	a957235
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6aa07a8b9d946c000890b6b5

[mbobrovskyi]

Thank you for cherry-pick!

/lgtm

[kubernetes-prow]

LGTM label has been added.

Details

Git tree hash: 7d689c31191d56a968a354282f05382b850d2350

[Copilot]

🟢 Approval recommended

The controller change is narrowly scoped to OnHold scale-up handling and is covered by a targeted integration test for the reported bug scenario.

Pull request overview

Cherry-picks the fix from #15279 onto release-0.19 to ensure StatefulSet-backed Workloads are resized correctly when a StatefulSet is scaled down to zero and then scaled back up to a different replica count, preventing incorrect pod-count quota accounting/admission.

Changes:

• Resync Workload.spec.podSets[].count when clearing the OnHold state so re-admission uses the current StatefulSet replica count.
• Add integration coverage for StatefulSet pod gating behavior during rollouts (current vs update revision).
• Add an integration test validating Workload resize behavior when scaling 0 → N with a different N than the original.

File summaries

File	Description
pkg/controller/jobs/statefulset/statefulset_reconciler.go	Updates reconcile flow to apply desired PodSet counts before clearing OnHold, fixing stale Workload sizing on re-admission.
test/integration/singlecluster/controller/jobs/statefulset/statefulset_controller_test.go	Adds integration tests for rollout gating behavior and for resizing Workload pod count after a 0 → N scale-up to a different size.

Review details

• Files reviewed: 2/2 changed files
• Comments generated: 1
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[mimowo]

/lgtm
/approve
/test pull-kueue-verify-release-0-19

[kubernetes-prow]

LGTM label has been added.

Details

Git tree hash: 1a4f3472fabc4da904ca03334725c239e51d4bfc

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mimowo, sohankunkerkar

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mimowo,sohankunkerkar]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment