[cryo-zd]

What type of PR is this?

/kind bug

What this PR does / why we need it:

Corrects the expected and actual PodSet counts in invalid PodSet info error message.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Currently none.

Does this PR introduce a user-facing change?

Fix a bug where invalid PodSet info errors to report the expected and actual PodSet counts in the correct order.

Summary by CodeRabbit

• Bug Fixes
  • Corrected the podset count error message so expected and actual values are displayed in the proper order.

[netlify]

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	391abdd
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6a6b7bd2792cf10008f801c5
😎 Deploy Preview	https://deploy-preview-13671--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[kubernetes-prow]

Hi @cryo-zd. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[coderabbitai]

📝 Walkthrough

Walkthrough

The podset length error formatting was corrected so messages report the expected podset count before the actual count.

Changes

Podset error reporting

Layer / File(s)	Summary
Correct podset count formatting pkg/podset/podset.go	BadPodSetsInfoLenError now formats the expected count before the actual count.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: benkermani

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the change: it fixes the PodSet count error message.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

🧹 Nitpick comments (1)

pkg/podset/podset.go (1)

242-242: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick win

Add a regression test for the corrected count ordering.

The implementation now matches the contract. Please ensure pkg/podset/podset_test.go asserts distinct values, such as want=2, got=3, render as expecting 2 podset, got 3.

AI-assisted review disclosure: this review was generated with AI assistance. As per coding guidelines, AI usage must be disclosed in pull request descriptions, comments, and issue filings.

🤖 Prompt for AI Agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

In `@pkg/podset/podset.go` at line 242, Extend the podset validation tests in
podset_test.go to cover distinct expected and actual counts, such as want=2 and
got=3, and assert the resulting error string is “expecting 2 podset, got 3”.

Source: Coding guidelines

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Nitpick comments:
In `@pkg/podset/podset.go`:
- Line 242: Extend the podset validation tests in podset_test.go to cover
distinct expected and actual counts, such as want=2 and got=3, and assert the
resulting error string is “expecting 2 podset, got 3”.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: f817e8a2-ea4e-452d-82a5-6255eaeeeb72

📥 Commits

Reviewing files that changed from the base of the PR and between 060599f and 391abdd.

📒 Files selected for processing (1)

• pkg/podset/podset.go

[mimowo]

/ok-to-test
/lgtm
/approve
/cherrypick release-0.19
/cherrypick release-0.18

[k8s-infra-cherrypick-robot]

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.18, release-0.19 in new PRs and assign them to you.

Details

In response to this:

/ok-to-test
/lgtm
/approve
/cherrypick release-0.19
/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[kubernetes-prow]

LGTM label has been added.

Details

Git tree hash: e7b9c3b0fe13e5e11987ddc6c2bf2e649be98e47

[kubernetes-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cryo-zd, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

• OWNERS [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[k8s-infra-cherrypick-robot]

@mimowo: new pull request created: #13672

Details

In response to this:

/ok-to-test
/lgtm
/approve
/cherrypick release-0.19
/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[k8s-infra-cherrypick-robot]

@mimowo: new pull request created: #13673

Details

In response to this:

/ok-to-test
/lgtm
/approve
/cherrypick release-0.19
/cherrypick release-0.18

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[tenzen-y]

/release-note-edit

Fix a bug where invalid PodSet info errors to report the expected and actual PodSet counts in the correct order.