✨ อัปเดตล่าสุด: kubernetes sigs/kueue/pull/

anuragdalvi · 2026-07-10T01:01:36Z

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Fixed stale pending queue entries when a pending Workload transitions to on-hold.

Which issue(s) this PR fixes:

Fixes #12685

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Scheduling: Fixed stale scheduling queue entries for pending Workloads that transition
to `WorkloadOnHold`.

Summary by CodeRabbit

Bug Fixes
- On-hold workloads are now removed from pending queues instead of remaining as stale entries.
- Prevents on-hold workloads from appearing incorrectly in pending workload listings.

…Hold

netlify · 2026-07-10T01:01:42Z

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name	Link
🔨 Latest commit	`a1e898a`
🔍 Latest deploy log	https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/6a5044732c918a00086b5790
😎 Deploy Preview	https://deploy-preview-12929--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

kubernetes-prow · 2026-07-10T01:01:47Z

Hi @anuragdalvi. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

coderabbitai · 2026-07-10T01:01:58Z

📝 Walkthrough

Walkthrough

The pending-to-pending workload update path now deletes workloads that enter the on-hold state. A unit test verifies that an existing pending queue entry is removed when the workload receives the on-hold condition.

Changes

On-hold queue cleanup

Layer / File(s)	Summary
Reconcile and validate on-hold queue removal `pkg/controller/core/workload_controller.go`, `pkg/controller/core/workload_controller_test.go`	The reconciler calls `DeleteWorkload` for on-hold workloads, and a test verifies removal of a stale pending queue entry.

Estimated code review effort: 2 (Simple) | ~10 minutes

Possibly related PRs

kubernetes-sigs/kueue#12233: Both changes modify pending workload queue handling for held workloads.

Suggested labels: release-note-none

Suggested reviewers: PBundyra, sohankunkerkar, kannon92

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Linked Issues check	✅ Passed	The code and test changes satisfy issue `#12685` by removing stale queue entries for on-hold workloads.
Out of Scope Changes check	✅ Passed	The changes are narrowly scoped to the queue cleanup fix and its regression test.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title accurately summarizes the main fix: deleting queue entries when a pending workload becomes WorkloadOnHold.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

anuragdalvi · 2026-07-10T01:04:29Z

/remove-label area/dashboard
/remove-label area/integrations
/remove-label area/localization
/remove-label area/multikueue
/remove-label area/tas
/remove-label area/testing
/remove-label area/website
/remove-label kind/api-change
/remove-label kind/cleanup
/remove-label kind/deprecation
/remove-label kind/failing-test
/remove-label kind/flake
/remove-label kind/regression

kubernetes-prow · 2026-07-10T01:04:33Z

@anuragdalvi: The label(s) /remove-label area/dashboard , /remove-label area/integrations , /remove-label area/localization , /remove-label area/multikueue , /remove-label area/tas , /remove-label area/testing , /remove-label area/website , /remove-label kind/api-change , /remove-label kind/cleanup , /remove-label kind/deprecation , /remove-label kind/failing-test , /remove-label kind/flake , /remove-label kind/regression cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/remove-label area/dashboard
/remove-label area/integrations
/remove-label area/localization
/remove-label area/multikueue
/remove-label area/tas
/remove-label area/testing
/remove-label area/website
/remove-label kind/api-change
/remove-label kind/cleanup
/remove-label kind/deprecation
/remove-label kind/failing-test
/remove-label kind/flake
/remove-label kind/regression

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

anuragdalvi · 2026-07-10T01:06:46Z

/remove-label area/dashboard

kubernetes-prow · 2026-07-10T01:06:49Z

@anuragdalvi: The label(s) /remove-label area/dashboard cannot be applied. These labels are supported: api-review, tide/merge-method-merge, tide/merge-method-rebase, tide/merge-method-squash, team/katacoda, refactor, ci-short, ci-extended, ci-full. Is this label configured under labels -> additional_labels or labels -> restricted_labels in plugin.yaml?

Details

In response to this:

/remove-label area/dashboard

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

anuragdalvi · 2026-07-10T01:07:33Z

/remove-area dashboard

anuragdalvi · 2026-07-10T01:08:51Z

/remove-area integrations
/remove-area localization
/remove-area multikueue
/remove-area tas
/remove-area testing
/remove-area website

anuragdalvi · 2026-07-10T01:10:41Z

/kind bug

mimowo · 2026-07-10T06:09:56Z

/ok-to-test

mimowo · 2026-07-10T06:39:18Z

/release-note-edit

Scheduling: Fixed stale scheduling queue entries for pending Workloads that transition
to `WorkloadOnHold`.

mimowo · 2026-07-10T06:40:29Z

Thank you 👍
/lgtm
/approve

Let me try to prep the CPs, but for what I can see 0.17 will probably fail anyway. @anuragdalvi would you like to prep the CP manually for 0.17?
/cherrypick release-0.18
/cherrypick release-0.17

k8s-infra-cherrypick-robot · 2026-07-10T06:40:31Z

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.17, release-0.18 in new PRs and assign them to you.

Details

In response to this:

Thank you 👍
/lgtm
/approve

Let me try to prep the CPs, but for what I can see 0.17 will probably fail anyway. @anuragdalvi would you like to prep the CP manually for 0.17?
/cherrypick release-0.18
/cherrypick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

kubernetes-prow · 2026-07-10T06:40:37Z

LGTM label has been added.

Details

Git tree hash: 1bbbce992cda7f67241eb0d7499872a0da0a55f2

kubernetes-prow · 2026-07-10T06:40:39Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: anuragdalvi, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details

Needs approval from an approver in each of these files:

~~pkg/controller/OWNERS~~ [mimowo]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

k8s-infra-cherrypick-robot · 2026-07-10T07:09:14Z

@mimowo: new pull request created: #12942

Details

In response to this:

Thank you 👍
/lgtm
/approve

Let me try to prep the CPs, but for what I can see 0.17 will probably fail anyway. @anuragdalvi would you like to prep the CP manually for 0.17?
/cherrypick release-0.18
/cherrypick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-infra-cherrypick-robot · 2026-07-10T07:09:50Z

@mimowo: #12929 failed to apply on top of branch "release-0.17":

Applying: call DeleteWorkload when a pending workload transitions to WorkloadOnHold
Using index info to reconstruct a base tree...
M	pkg/controller/core/workload_controller.go
M	pkg/controller/core/workload_controller_test.go
Falling back to patching base and 3-way merge...
Auto-merging pkg/controller/core/workload_controller.go
CONFLICT (content): Merge conflict in pkg/controller/core/workload_controller.go
Auto-merging pkg/controller/core/workload_controller_test.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config set advice.mergeConflict false"
Patch failed at 0001 call DeleteWorkload when a pending workload transitions to WorkloadOnHold

Details

In response to this:

Thank you 👍
/lgtm
/approve

Let me try to prep the CPs, but for what I can see 0.17 will probably fail anyway. @anuragdalvi would you like to prep the CP manually for 0.17?
/cherrypick release-0.18
/cherrypick release-0.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

anuragdalvi · 2026-07-10T15:05:59Z

@mimowo Thanks for the CP for release-0.17

mimowo · 2026-07-10T15:13:51Z

Np, we have a release today so I wanted to make sure it doesn't slip. Normally, I would just leave it to the contributor

call DeleteWorkload when a pending workload transitions to WorkloadOn…

a1e898a

…Hold

kubernetes-prow Bot requested review from kshalot and olekzabl July 10, 2026 01:01

kubernetes-prow Bot added area/website Issues or PRs related to the website size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 10, 2026

kubernetes-prow Bot removed the area/dashboard Denotes a PR that is related to the built-in dashboard label Jul 10, 2026

kubernetes-prow Bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 10, 2026

kubernetes-prow Bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jul 10, 2026

kubernetes-prow Bot assigned mimowo Jul 10, 2026

kubernetes-prow Bot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 10, 2026

kubernetes-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 10, 2026

kubernetes-prow Bot merged commit a27c6fd into kubernetes-sigs:main Jul 10, 2026
55 checks passed

kubernetes-prow Bot added this to the v0.19 milestone Jul 10, 2026

k8s-infra-cherrypick-robot mentioned this pull request Jul 10, 2026

[release-0.18] call DeleteWorkload when a pending workload transitions to WorkloadOnHold #12942

Merged

mimowo mentioned this pull request Jul 10, 2026

Automated cherry pick of #12929: call DeleteWorkload when a pending workload transitions to WorkloadOnHold #12948

Merged

Conversation

anuragdalvi commented Jul 10, 2026 • edited by kubernetes-prow Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What type of PR is this?

What this PR does / why we need it:

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

Summary by CodeRabbit

Uh oh!

netlify Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Uh oh!

kubernetes-prow Bot commented Jul 10, 2026

Uh oh!

coderabbitai Bot commented Jul 10, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

anuragdalvi commented Jul 10, 2026

Uh oh!

kubernetes-prow Bot commented Jul 10, 2026

Uh oh!

anuragdalvi commented Jul 10, 2026

Uh oh!

kubernetes-prow Bot commented Jul 10, 2026

Uh oh!

anuragdalvi commented Jul 10, 2026

Uh oh!

anuragdalvi commented Jul 10, 2026

Uh oh!

anuragdalvi commented Jul 10, 2026

Uh oh!

mimowo commented Jul 10, 2026

Uh oh!

mimowo commented Jul 10, 2026

Uh oh!

mimowo commented Jul 10, 2026

Uh oh!

k8s-infra-cherrypick-robot commented Jul 10, 2026

Uh oh!

kubernetes-prow Bot commented Jul 10, 2026

Uh oh!

kubernetes-prow Bot commented Jul 10, 2026

Uh oh!

Uh oh!

k8s-infra-cherrypick-robot commented Jul 10, 2026

Uh oh!

k8s-infra-cherrypick-robot commented Jul 10, 2026

Uh oh!

anuragdalvi commented Jul 10, 2026

Uh oh!

mimowo commented Jul 10, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

anuragdalvi commented Jul 10, 2026 •

edited by kubernetes-prow Bot

Loading

netlify Bot commented Jul 10, 2026 •

edited

Loading

coderabbitai Bot commented Jul 10, 2026 •

edited

Loading