Skip to content

helm: use fullname template for FlowSchema priorityLevelConfiguration reference - #10979

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
cixuuz:fix/helm-flowschema-plc-name-v2
May 6, 2026
Merged

helm: use fullname template for FlowSchema priorityLevelConfiguration reference#10979
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
cixuuz:fix/helm-flowschema-plc-name-v2

Conversation

@cixuuz

@cixuuz cixuuz commented May 6, 2026 •
edited by k8s-ci-robot
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

/kind bug

What this PR does / why we need it:

The FlowSchema's spec.priorityLevelConfiguration.name was hardcoded as kueue-visibility instead of using the Helm fullname template. When fullnameOverride or nameOverride is set in Helm values, the FlowSchema references a non-existent PriorityLevelConfiguration, breaking the visibility API's API Priority and Fairness configuration.

Which issue(s) this PR fixes:

Fixes #10934

Changes:

  1. config/components/visibility-apf/flowschema.yaml: Changed priorityLevelConfiguration.name from kueue-visibility to visibility (consistent with how metadata.name is handled — kustomize nameReference propagates the prefix automatically)
  2. hack/processing-plan.yaml: Added an APPEND operation for .spec.priorityLevelConfiguration.name so the yaml-processor generates the correct Helm template
  3. charts/kueue/templates/visibility-apf/flowschema.yaml: Updated the generated template to use {{ include "kueue.fullname" . }}-visibility instead of the hardcoded value
Helm: Fixed the FlowSchema priorityLevelConfiguration reference to use the Helm fullname template, preventing APF configuration from breaking when fullnameOverride or nameOverride is set.

@cixuuz
helm: use fullname template for FlowSchema priorityLevelConfiguration…
03904a5 
… reference

The FlowSchema's spec.priorityLevelConfiguration.name was hardcoded as
'kueue-visibility' instead of using the Helm fullname template. When
fullnameOverride or nameOverride is set, the FlowSchema references a
non-existent PriorityLevelConfiguration, breaking the visibility API's
APF configuration.

Fix:
- Update config source to use plain 'visibility' name (consistent with
  metadata.name pattern; kustomize nameReference handles the prefix)
- Add APPEND operation in processing-plan.yaml for the PLC name field
- Regenerate the Helm template to use the fullname template

```release-note
Fixed FlowSchema priorityLevelConfiguration using hardcoded name instead of Helm fullname template, which broke APF when fullnameOverride or nameOverride was set.
```
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. labels May 6, 2026
@netlify

netlify Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-kueue ready!

Name Link
🔨 Latest commit 03904a5
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69fadc5a7200130008e36fe0
😎 Deploy Preview https://deploy-preview-10979--kubernetes-sigs-kueue.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 6, 2026
@k8s-ci-robot

k8s-ci-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Hi @cixuuz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 6, 2026
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 6, 2026
@mimowo

mimowo commented May 6, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2026
@mimowo

mimowo commented May 6, 2026

Copy link
Copy Markdown
Contributor

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.16, release-0.17 in new PRs and assign them to you.

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2026
@k8s-ci-robot

k8s-ci-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: d16e8fe7bf5221a5719147b2deef4b5ebd51c216

@k8s-ci-robot

k8s-ci-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cixuuz, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 4e72afa into kubernetes-sigs:main May 6, 2026
33 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.18 milestone May 6, 2026
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

@mimowo: new pull request created: #10981

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 6, 2026
Merged
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

@mimowo: new pull request created: #10983

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 6, 2026
Merged
hiboyang pushed a commit to hiboyang/kueue_oss that referenced this pull request May 8, 2026
@cixuuz @hiboyang
helm: use fullname template for FlowSchema priorityLevelConfiguration…
b838f6d 
… reference (kubernetes-sigs#10979)

The FlowSchema's spec.priorityLevelConfiguration.name was hardcoded as
'kueue-visibility' instead of using the Helm fullname template. When
fullnameOverride or nameOverride is set, the FlowSchema references a
non-existent PriorityLevelConfiguration, breaking the visibility API's
APF configuration.

Fix:
- Update config source to use plain 'visibility' name (consistent with
  metadata.name pattern; kustomize nameReference handles the prefix)
- Add APPEND operation in processing-plan.yaml for the PLC name field
- Regenerate the Helm template to use the fullname template

```release-note
Fixed FlowSchema priorityLevelConfiguration using hardcoded name instead of Helm fullname template, which broke APF when fullnameOverride or nameOverride was set.
```
@mimowo

mimowo commented May 15, 2026

Copy link
Copy Markdown
Contributor

/release-note-edit

Helm: Fixed the FlowSchema priorityLevelConfiguration reference to use the Helm fullname template, preventing APF configuration from breaking when fullnameOverride or nameOverride is set.

falconlee236 pushed a commit to falconlee236/kueue that referenced this pull request May 24, 2026
@cixuuz @falconlee236
helm: use fullname template for FlowSchema priorityLevelConfiguration…
059fa5f 
… reference (kubernetes-sigs#10979)

The FlowSchema's spec.priorityLevelConfiguration.name was hardcoded as
'kueue-visibility' instead of using the Helm fullname template. When
fullnameOverride or nameOverride is set, the FlowSchema references a
non-existent PriorityLevelConfiguration, breaking the visibility API's
APF configuration.

Fix:
- Update config source to use plain 'visibility' name (consistent with
  metadata.name pattern; kustomize nameReference handles the prefix)
- Add APPEND operation in processing-plan.yaml for the PLC name field
- Regenerate the Helm template to use the fullname template

```release-note
Fixed FlowSchema priorityLevelConfiguration using hardcoded name instead of Helm fullname template, which broke APF when fullnameOverride or nameOverride was set.
```
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92
@mbobrovskyi mbobrovskyi Awaiting requested review from mbobrovskyi

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.18

Development

Successfully merging this pull request may close these issues.

[Helm] FlowSchema priorityLevelConfiguration uses hardcoded name instead of Helm template

5 participants

@cixuuz @k8s-ci-robot @mimowo @k8s-infra-cherrypick-robot @tenzen-y