Skip to content

fix(kueueviz): use plural workloadpriorityclasses in ClusterRole RBAC - #10977

Merged
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
cixuuz:fix/kueueviz-rbac-plural-v2
May 6, 2026
Merged

fix(kueueviz): use plural workloadpriorityclasses in ClusterRole RBAC#10977
k8s-ci-robot merged 1 commit into
kubernetes-sigs:mainfrom
cixuuz:fix/kueueviz-rbac-plural-v2

Conversation

@cixuuz

@cixuuz cixuuz commented May 6, 2026 •
edited by k8s-ci-robot
Loading

Copy link
Copy Markdown
Contributor

What

Fixes the KueueViz ClusterRole to use the plural form workloadpriorityclasses instead of the singular workloadpriorityclass in the RBAC resources field.

Why

Kubernetes RBAC resources requires the plural form of the resource name. The singular form silently matches nothing, so the KueueViz backend has no access to WorkloadPriorityClass objects.

The main controller role in templates/rbac/role.yaml correctly uses the plural form — this was just missed in the KueueViz clusterrole.

Changes

  • config/components/kueueviz/clusterrole.yaml: workloadpriorityclass → workloadpriorityclasses
  • charts/kueue/templates/kueueviz/clusterrole.yaml: same fix in the generated Helm template
KueueViz: Fixed RBAC permissions for WorkloadPriorityClass objects by using the correct plural workloadpriorityclasses resource name.

@k8s-ci-robot k8s-ci-robot added do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 6, 2026
@netlify

netlify Bot commented May 6, 2026 •
edited
Loading

Copy link
Copy Markdown

✅ Deploy Preview for kubernetes-sigs-kueue canceled.

Name Link
🔨 Latest commit cf5b9ec
🔍 Latest deploy log https://app.netlify.com/projects/kubernetes-sigs-kueue/deploys/69fadacbdf970c00081836b7

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 6, 2026
@k8s-ci-robot

k8s-ci-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

Hi @cixuuz. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot
k8s-ci-robot requested review from kannon92 and kshalot May 6, 2026 06:06
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 6, 2026
@cixuuz
fix(kueueviz): use plural 'workloadpriorityclasses' in ClusterRole RBAC
cf5b9ec 
The RBAC resources field requires the plural form of the resource name.
The singular 'workloadpriorityclass' silently matches no resources,
leaving the KueueViz backend unable to access WorkloadPriorityClass objects.
@cixuuz
cixuuz force-pushed the fix/kueueviz-rbac-plural-v2 branch from ed1814b to cf5b9ec Compare May 6, 2026 06:08
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. and removed do-not-merge/invalid-commit-message Indicates that a PR should not merge because it has an invalid commit message. do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels May 6, 2026
@mimowo

mimowo commented May 6, 2026

Copy link
Copy Markdown
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 6, 2026
@mimowo

mimowo commented May 6, 2026

Copy link
Copy Markdown
Contributor

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

@mimowo: once the present PR merges, I will cherry-pick it on top of release-0.16, release-0.17 in new PRs and assign them to you.

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 6, 2026
@k8s-ci-robot

k8s-ci-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

LGTM label has been added.

DetailsGit tree hash: 01a763cbe8d9e20c207a05a166550abb30ab4e7f

@k8s-ci-robot

k8s-ci-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cixuuz, mimowo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 6, 2026
@k8s-ci-robot
k8s-ci-robot merged commit 9def9f4 into kubernetes-sigs:main May 6, 2026
33 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v0.18 milestone May 6, 2026
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

@mimowo: new pull request created: #10984

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 6, 2026
Merged
@k8s-infra-cherrypick-robot

k8s-infra-cherrypick-robot commented May 6, 2026

Copy link
Copy Markdown
Contributor

@mimowo: new pull request created: #10985

Details

In response to this:

Thank you 👍
/lgtm
/approve
/cherrypick release-0.17
/cherrypick release-0.16

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-infra-cherrypick-robot k8s-infra-cherrypick-robot mentioned this pull request May 6, 2026
Merged
@mimowo

mimowo commented May 6, 2026

Copy link
Copy Markdown
Contributor

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label May 6, 2026
hiboyang pushed a commit to hiboyang/kueue_oss that referenced this pull request May 8, 2026
@cixuuz @hiboyang
fix(kueueviz): use plural 'workloadpriorityclasses' in ClusterRole RB…
c402834 
…AC (kubernetes-sigs#10977)

The RBAC resources field requires the plural form of the resource name.
The singular 'workloadpriorityclass' silently matches no resources,
leaving the KueueViz backend unable to access WorkloadPriorityClass objects.
@mimowo

mimowo commented May 15, 2026

Copy link
Copy Markdown
Contributor

/release-note-edit

KueueViz: Fixed RBAC permissions for WorkloadPriorityClass objects by using the correct plural workloadpriorityclasses resource name.

falconlee236 pushed a commit to falconlee236/kueue that referenced this pull request May 24, 2026
@cixuuz @falconlee236
fix(kueueviz): use plural 'workloadpriorityclasses' in ClusterRole RB…
7d3e2ed 
…AC (kubernetes-sigs#10977)

The RBAC resources field requires the plural form of the resource name.
The singular 'workloadpriorityclass' silently matches no resources,
leaving the KueueViz backend unable to access WorkloadPriorityClass objects.
@bolubo bolubo mentioned this pull request Sep 9, 2026
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kannon92 kannon92 Awaiting requested review from kannon92
@kshalot kshalot Awaiting requested review from kshalot

Assignees

@mimowo mimowo

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v0.18

Development

Successfully merging this pull request may close these issues.

5 participants

@cixuuz @k8s-ci-robot @mimowo @k8s-infra-cherrypick-robot @tenzen-y