Skip to content

Show "Upgrading plugin %s" message - #438

Merged
k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
ahmetb:upgrade-indicator
Dec 20, 2019
Merged

Show "Upgrading plugin %s" message#438
k8s-ci-robot merged 2 commits into
kubernetes-sigs:masterfrom
ahmetb:upgrade-indicator

Conversation

@ahmetb

@ahmetb ahmetb commented Dec 17, 2019

Copy link
Copy Markdown
Member

Promoting this from log to user-visible message, because some plugins actually
are ~20-30 MiB and takes a significant time to download. During this time
we show no indication of progress while the download is happening.

/assign @corneliusweig

@ahmetb
Show "Upgrading plugin %s" message
ede9eb8 
Promoting this from log to user-visible message, because some plugins actually
are ~20-30 MiB and takes a significant time to download. During this time
we show no indication of progress while the download is happening.

Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Dec 17, 2019
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Dec 17, 2019
@corneliusweig

corneliusweig commented Dec 17, 2019

Copy link
Copy Markdown
Contributor

Love the change. There seems to be a problem with gofmt though.

@ahmetb

ahmetb commented Dec 18, 2019

Copy link
Copy Markdown
Member Author

friggin goland.

@ahmetb
gofmt
9ed2847 
Signed-off-by: Ahmet Alp Balkan <ahmetb@google.com>
@codecov-io

codecov-io commented Dec 18, 2019 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Merging #438 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #438   +/-   ##
=======================================
  Coverage   56.35%   56.35%           
=======================================
  Files          19       19           
  Lines         928      928           
=======================================
  Hits          523      523           
  Misses        350      350           
  Partials       55       55

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 36c755c...9ed2847. Read the comment docs.

ferhatelmas
ferhatelmas approved these changes Dec 18, 2019
View reviewed changes

@ferhatelmas ferhatelmas left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corneliusweig

corneliusweig commented Dec 20, 2019

Copy link
Copy Markdown
Contributor

/lgtm
/approve

Sorry for the delay.

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 20, 2019
@k8s-ci-robot

k8s-ci-robot commented Dec 20, 2019

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, corneliusweig

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:
  • OWNERS [ahmetb,corneliusweig]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
k8s-ci-robot merged commit ee1c25e into kubernetes-sigs:master Dec 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@corneliusweig corneliusweig Awaiting requested review from corneliusweig
@soltysh soltysh Awaiting requested review from soltysh
1 more reviewer
@ferhatelmas ferhatelmas ferhatelmas approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

@corneliusweig corneliusweig

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ahmetb @corneliusweig @codecov-io @k8s-ci-robot @ferhatelmas