Repository navigation
[fix _examples] response.timestamp not appear in correct request. - #1696
Merged
Merged
Conversation
|
|
kataras
requested changes
Jan 5, 2021
kataras
left a comment
kataras
left a comment
Owner
There was a problem hiding this comment.
Hello @cainiaoDJ ,
Thanks for the pull request!
You need to make changes before I can push that though.
The issue was that the *response implemented the Preflight interface but the example returned just a response value (no pointer) from the method handler, the rest of the changes are not actual helping, the opposite I could say. Why you cast the response with (*r)? Please remove unnecessary code and thanks for your contribution to the Iris Web Framework.
Happy new year!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We'd love to see more contributions
issue #1695