[vbalko-claimate]

Summary

Adds an update-bookmark MCP tool that wraps the existing PATCH /bookmarks/{bookmarkId} REST endpoint. Today the MCP server can create, read, search, tag and list-manage bookmarks, but it cannot modify them — clients have to fall back to the raw REST API to change something as simple as a title, a note, or the archived/favourited flags. This closes that gap.

Behaviour

• Tool name: update-bookmark.
• Required input: bookmarkId.
• Optional inputs (all map 1:1 to the PATCH request body): title, note, summary, archived, favourited, url, description, author, publisher, createdAt. Nullable fields accept null to clear them.
• Only the fields that are passed are sent; omitted fields stay unchanged on the server.
• The PATCH response schema does not include tags, content or assets, so after a successful PATCH the tool issues a follow-up GET /bookmarks/{bookmarkId} and returns the full compactBookmark(...) view so the LLM sees the final state.

Design notes

• I intentionally did not expose text, assetContent, datePublished, dateModified. text/assetContent can clobber crawler-populated content for link/asset bookmarks, and the date fields are rarely useful to an LLM. The OpenAPI endpoint still supports them; they can be added later if there's demand.
• Style matches the existing create-bookmark / get-bookmark tools in apps/mcp/src/bookmarks.ts (zod schema with per-field .describe(...), toMcpToolError on failure, compactBookmark on success).

Checks run locally

• pnpm --filter @karakeep/mcp typecheck — clean
• pnpm --filter @karakeep/mcp lint — 0 warnings, 0 errors
• pnpm --filter @karakeep/mcp format — all files correctly formatted (oxfmt)
• pnpm preflight — all 61 tasks green
• pre-commit hook (pnpm preflight && pnpm exec sherif && pnpm --filter @karakeep/open-api check) passed without bypass

Process note

CONTRIBUTING.md prefers work on status/approved issues. I didn't find an existing issue for this specific gap (mcp + update/patch bookmark search returns nothing concrete — only PR #1971, which reworks MCP transport but keeps the tool set unchanged). Since this is strict API-parity with an endpoint that already exists, I opened the PR directly — happy to convert it to an issue-first flow if you'd rather, or to extend it (e.g. expose the remaining patchable fields, add delete-bookmark) before merge.

[coderabbitai]

Walkthrough

A new MCP tool named update-bookmark is added to the bookmarks module. It accepts a bookmark ID and optional partial update fields, sends a PATCH request to update the bookmark, performs a follow-up GET request, and returns the updated bookmark data with error handling for failed requests.

Changes

Cohort / File(s)	Summary
MCP Bookmark Update Tool apps/mcp/src/bookmarks.ts	Added new update-bookmark MCP tool that patches bookmarks with optional fields (title, note, summary, archived, favourited, url, description, author, publisher, createdAt), validates responses, and returns formatted bookmark data.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title 'feat(mcp): add update-bookmark tool' directly and clearly describes the main change: adding a new MCP tool for updating bookmarks. It is specific and concise.
Description check	✅ Passed	The description is comprehensive and directly related to the changeset, explaining the new tool's purpose, behavior, design decisions, and local test results. It is clearly on-topic and provides meaningful context.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[greptile-apps]

Greptile Summary

Adds an update-bookmark MCP tool that wraps the existing PATCH /bookmarks/{bookmarkId} REST endpoint and follows a PATCH → GET pattern to return the full bookmark (including tags and content not in the PATCH response). The Zod schema, error handling, and nullable/optional field modeling all align correctly with zUpdateBookmarksRequestSchema and the SDK-generated types.

Confidence Score: 5/5

Safe to merge — clean implementation with no logic errors, correct type alignment, and consistent error handling.

All fields map correctly to the underlying API schema (verified against zUpdateBookmarksRequestSchema and karakeep-api.d.ts). The PATCH → GET pattern is sound, error paths are handled at every step, and the author confirmed typecheck, lint, and preflight all passed.

No files require special attention.

Important Files Changed

Filename	Overview
apps/mcp/src/bookmarks.ts	Adds update-bookmark MCP tool that PATCHes a bookmark then GETs the full record; schema, error handling, and types match the existing patterns and underlying API correctly.

_{Reviews (1): Last reviewed commit: "feat(mcp): add update-bookmark tool" | Re-trigger Greptile}

[coderabbitai]

🧹 Nitpick comments (2)

apps/mcp/src/bookmarks.ts (2)

191-202: Consider guarding against an empty update payload.

Since every field besides bookmarkId is optional, a caller can invoke update-bookmark with only an ID and the tool will issue a PATCH with an empty body, followed by an unnecessary GET. It's harmless but wasteful and easy for an LLM to do. A small early-exit (or a more descriptive error) would make the tool's contract clearer.

♻️ Possible early exit

 async ({ bookmarkId, ...fields }): Promise<CallToolResult> => {
+    if (Object.values(fields).every((v) => v === undefined)) {
+      return toMcpToolError("At least one field must be provided to update.");
+    }
     const patchRes = await karakeepClient.PATCH(`/bookmarks/{bookmarkId}`, {

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/mcp/src/bookmarks.ts` around lines 191 - 202, The update handler (the
async ({ bookmarkId, ...fields }): Promise<CallToolResult> => { ... }) should
guard against an empty update payload: before calling karakeepClient.PATCH check
if fields has no own keys (e.g., Object.keys(fields).length === 0) and return a
clear early result (an error via toMcpToolError or a descriptive CallToolResult
indicating "no fields to update") instead of issuing the PATCH and subsequent
GET; add the guard at the top of that function to avoid wasted network calls.

---

169-169: Use the standalone z.url() schema in Zod 4.

Zod 4 moved string format schemas (z.email(), z.url(), z.uuid()) to top-level functions as the idiomatic form. While z.string().url() still works, it is deprecated in favor of the cleaner z.url() API for better tree-shakability.

♻️ Proposed change

-    url: z.string().url().optional().describe(`New URL for a link bookmark.`),
+    url: z.url().optional().describe(`New URL for a link bookmark.`),

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@apps/mcp/src/bookmarks.ts` at line 169, Replace the deprecated
z.string().url() usage with the top-level z.url() in the Zod schema for the
"url" property: update the schema entry keyed by "url" in the bookmarks schema
(currently written as z.string().url().optional().describe(...)) to use
z.url().optional().describe(...) so it follows Zod 4 idioms and improves
tree-shakability.

🤖 Prompt for all review comments with AI agents

Verify each finding against the current code and only fix it if needed.

Nitpick comments:
In `@apps/mcp/src/bookmarks.ts`:
- Around line 191-202: The update handler (the async ({ bookmarkId, ...fields
}): Promise<CallToolResult> => { ... }) should guard against an empty update
payload: before calling karakeepClient.PATCH check if fields has no own keys
(e.g., Object.keys(fields).length === 0) and return a clear early result (an
error via toMcpToolError or a descriptive CallToolResult indicating "no fields
to update") instead of issuing the PATCH and subsequent GET; add the guard at
the top of that function to avoid wasted network calls.
- Line 169: Replace the deprecated z.string().url() usage with the top-level
z.url() in the Zod schema for the "url" property: update the schema entry keyed
by "url" in the bookmarks schema (currently written as
z.string().url().optional().describe(...)) to use
z.url().optional().describe(...) so it follows Zod 4 idioms and improves
tree-shakability.

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: f03d6eeb-5334-4b9b-a123-e546cbc9956a

📥 Commits

Reviewing files that changed from the base of the PR and between f67f184 and e52bdf1.

📒 Files selected for processing (1)

• apps/mcp/src/bookmarks.ts

[MohamedBassem]

Thank you!