Repository navigation
Additional comments about indexing phase, no functional change - #259
Merged
Merged
Conversation
Owner
|
@nigels-com thanks, const correctness is always great to have! I have been longing to refresh and clean up the code for so long, but it never became a priority... 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm taking a fresh look at improving the indexing performance of nanoflann.
Along the way I added further inline comments about
divideTreeanddivideTreeConcurrentwhich may be helpful to others.Some more const and a typo fix also.