Redefine click.pass_context and click.get_current_context to use cloup.Context in place of click.Context - #171
Merged
Conversation
Author
|
Would be good for somebody experienced to review. I am no full time dev. |
…oup.Context (not click.Context)
janluke
changed the title
click.pass_context and click.get_current_context to use cloup.Context in place of click.Context
janluke
force-pushed
the
pass_context_fix
branch
from
November 13, 2023 01:48
3f14093 to
edea710
Compare
Owner
|
@oeko2002 The PR was fine, thanks. I added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR redefines
click.pass_contextandclick.get_current_contextso that the type of the returnedContextobject iscloup.Contextand notclick.Context.I (@janluke) used
@overloadto provide better type annotations forcloup.get_current_context: if thesilentargument is not provided, the return type isContext, notOptional[Context].