Repository navigation
Add initial frontend quality gates and TypeScript hardening - #418
Merged
jamiepine merged 1 commit intoApr 18, 2026
Merged
Conversation
Contributor
Author
|
Follow-up tracking issues opened from this hardening pass:
That gives the repo a cleaner path from âmake CI meaningfulâ to âmake architecture maintainable.â |
Contributor
Author
|
I spun up the next slice as a stacked follow-up PR on my fork: That branch introduces explicit engine/platform support tiers and lazy-loads the heavy routes. Local verification dropped the main web bundle from about 1069 kB to about 637 kB minified while keeping I kept it stacked on top of this hardening PR so the review surface stays sane instead of mixing architecture work into the first patch. |
jamiepine
added a commit
that referenced
this pull request
Apr 18, 2026
ModelManagement.tsx reads migrationResult.moved (added in #433) but apiClient.migrateModels() was typed as returning only { source, destination }. The backend actually returns { moved: int, errors: list[str], source, destination } (backend/routes/models.py:140, 168). Widen the TS return type so the check typechecks under the new CI gate from #418. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2 tasks
jamiepine
added a commit
that referenced
this pull request
Apr 18, 2026
#470) ModelManagement.tsx reads migrationResult.moved (added in #433) but apiClient.migrateModels() was typed as returning only { source, destination }. The backend actually returns { moved: int, errors: list[str], source, destination } (backend/routes/models.py:140, 168). Widen the TS return type so the check typechecks under the new CI gate from #418. Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun run cimeaningful and passingWhy
Verification
bun run typecheckbun run build:webbun run ciNotes
biome checkyet because the repo still has substantial pre-existing formatting/a11y debt that would keep CI permanently red.