Repository navigation
Remove unused imports in docs. - #406
Merged
Merged
Conversation
vwxyzjn
commented
Jun 5, 2023
lvwerra
reviewed
Jun 6, 2023
|
The documentation is not available anymore as the PR was closed or merged. |
Contributor
Author
|
Thanks @lvwerra for the review. I added an end-to-end test as well. |
lvwerra
approved these changes
Jun 6, 2023
lvwerra
left a comment
lvwerra
left a comment
Member
There was a problem hiding this comment.
LGTM! 🚀 just one small comment!
younesbelkada
left a comment
younesbelkada
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for the great work and welcome to TRL! 🚀
We just need to address:
examples/hello_world.py:6:1: F401 'trl.core.LengthSampler' imported but unused
examples/hello_world.py:6:1: F401 'trl.core.respond_to_batch' imported but unused
So that the code quality checker will be happy - you can just do
make style && make quality
After that we can merge the PR! 💪
Nice test btw :D !
Contributor
Author
|
@younesbelkada Thanks for bearing with me, and I appreciate your review! |
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
* remove unused var * bug fix * update docs, add e2e CI * black * isort * CI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor minor improvement on docs :)