Skip to content

fix dataloader typo in ppo_trainer.py - #389

Merged
lvwerra merged 2 commits into
huggingface:mainfrom
LZY-the-boys:main
May 30, 2023
Merged

lvwerra merged 2 commits into
huggingface:mainfrom
LZY-the-boys:main

Conversation

@LZY-the-boys

Copy link
Copy Markdown
Contributor

dataloader must be a torch.utils.data.Dataset: dataloader should be dataset

`dataloader must be a torch.utils.data.Dataset`: `dataloader` should be `dataset`

@lvwerra lvwerra left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented May 26, 2023 •

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

@lvwerra
lvwerra merged commit 86c1174 into huggingface:main May 30, 2023
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
`dataloader must be a torch.utils.data.Dataset`: `dataloader` should be `dataset`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants