Repository navigation
add is_trainable in kwargs - #363
Merged
Merged
Conversation
Add is_trainable in kwargs to enable continue training of peft model.
|
The documentation is not available anymore as the PR was closed or merged. |
younesbelkada
approved these changes
May 12, 2023
younesbelkada
left a comment
younesbelkada
left a comment
Contributor
There was a problem hiding this comment.
Thanks a lot for the clean work!
This looks great to me!
lvwerra
approved these changes
May 15, 2023
yxliu-TAMU
pushed a commit
to mincheolseong/ECEN743-GRPO-Project-Proposal
that referenced
this pull request
Apr 20, 2025
Add is_trainable in kwargs to enable continue training of peft model.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR enables continue training of peft model by add
is_trainableas akwargonfrom_pretainedofPreTrainedWrapper. (ref. #342 (comment))is_trainableis a parameter ofPeftModel.from_pretrained()which enable continue training.LoraConfigdo not haveis_trainableparameter.Use case example: huggingface/peft#282 (comment)
Source: https://github.com/huggingface/peft/blob/main/src/peft/peft_model.py#L145
cc @lvwerra @younesbelkada