Repository navigation
140/best n sampling - #326
Conversation
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
|
The documentation is not available anymore as the PR was closed or merged. |
| @@ -0,0 +1,680 @@ | |||
| { | |||
There was a problem hiding this comment.
Maybe add a few sentences to explain the motivation of the notebook and what does it showcases
Reply via ReviewNB
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Thanks a lot for this!
Can you also add few notes in the notebook and the README.md file of examples explaining the demonstration?
From my understanding this is a new rollout strategy that a user can use in replacement of the existing one. So this should be highlighted for better understanding and broader adoption
|
@younesbelkada thank you for the review. I took the liberty of shifting the notebook to a directory within |
younesbelkada
left a comment
younesbelkada
left a comment
There was a problem hiding this comment.
Awesome work! Thanks a lot for your contribution
|
Sorry was a little swamped with travel and stuff last week, but I'm stoked about this @metric-space ! |
|
Hey folks, I just realized that the description was edited to say this fixes #140 (implies finality to me) but I think the notebook is a precursor to actual framework code for
Happy to put in the work to get said additions in. Just waiting on more PR reviews to see whether I'm in the clear |
|
Hey folks @natolambert and @younesbelkada, hate to poke/ping people but also don't want this development to remain dormant and go cold. Any word on this? |
|
Looks good to me. Let's merge the notebook and think about |
|
Thank you folks for this and I appreciate the response. I'll start up a draft PR and conversations on the thread (if needed) around the |
* Create best_of_n.ipynb * First draft * Refactor as ref vs ppo vs non-ppo * Changed notebook location and added README to explain motivation * 1. Spelling and formatting refactor 2. Minor refactor of notebook * Formatting of notebook
5 participants
Attempts to deliver work for #140
Fixes #140
Gist
Showcase usage of best-of-n sampling