Skip to content

added doc for using torch.distributed.launch/run - #324

Merged
younesbelkada merged 3 commits into
huggingface:mainfrom
oroojlooy:main
Apr 28, 2023
Merged

added doc for using torch.distributed.launch/run#324
younesbelkada merged 3 commits into
huggingface:mainfrom
oroojlooy:main

Conversation

@oroojlooy

@oroojlooy oroojlooy commented Apr 26, 2023

Copy link
Copy Markdown
Contributor

Following up on #317, I created this PR.

@oroojlooy oroojlooy mentioned this pull request Apr 26, 2023
Closed
@HuggingFaceDocBuilderDev

HuggingFaceDocBuilderDev commented Apr 26, 2023 •
edited
Loading

Copy link
Copy Markdown

The documentation is not available anymore as the PR was closed or merged.

younesbelkada
younesbelkada approved these changes Apr 26, 2023
View reviewed changes

@younesbelkada younesbelkada left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this!
For some reason the diff also shows that you have added the paragraph ### Run on multiple GPUs / node, but it seems that everything is correct as expected when looking at the generated documentation. Could you maybe merge your branch with trl's main branch?

cc @lvwerra

Comment thread docs/source/customization.mdx Outdated
@oroojlooy

oroojlooy commented Apr 26, 2023

Copy link
Copy Markdown
Contributor Author

Thanks a lot for this! For some reason the diff also shows that you have added the paragraph ### Run on multiple GPUs / node, but it seems that everything is correct as expected when looking at the generated documentation. Could you maybe merge your branch with trl's main branch?

cc @lvwerra

That was weird for me as well. I cloned the repo this morning to have a clean commit. Do you want me to re-do that with a new clone?

@younesbelkada

younesbelkada commented Apr 28, 2023

Copy link
Copy Markdown
Contributor

I have updated your branch for you! Will merge once it is green

@younesbelkada
younesbelkada merged commit 08f5506 into huggingface:main Apr 28, 2023
yxliu-TAMU pushed a commit to mincheolseong/ECEN743-GRPO-Project-Proposal that referenced this pull request Apr 20, 2025
@oroojlooy @afshinoroojlooy @younesbelkada
added doc for using torch.distributed.launch/run (huggingface#324)
1e4270b 
* added doc for using torch.distributed.launch/run

* Update docs/source/customization.mdx

---------

Co-authored-by: Afshin Oroojlooyjadid <afshin.oroojlooyjadid@oracle.com>
Co-authored-by: younesbelkada <younesbelkada@gmail.com>
Co-authored-by: Younes Belkada <49240599+younesbelkada@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@younesbelkada younesbelkada younesbelkada approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@oroojlooy @HuggingFaceDocBuilderDev @younesbelkada @afshinoroojlooy