Skip to content

fix(hono-base): disallow getPath when strict is false - #5563

Merged
yusukebe merged 1 commit into
mainfrom
fix/strict-false-excludes-get-path
Oct 17, 2026
Merged

yusukebe merged 1 commit into
mainfrom
fix/strict-false-excludes-get-path

Conversation

@yusukebe

Copy link
Copy Markdown
Member

The author should do the following, if applicable

  • Add tests
  • Run tests
  • pnpm run check:fix to format and lint the code
  • Add TSDoc/JSDoc to document the code

@github-actions

Copy link
Copy Markdown

Bundle size check

main (08807ce) #5563 (2ffa48d) +/-
Bundle Size (B) 18,379B 18,379B 0B
Bundle Size (KB) 17.95K 17.95K 0K

Compiler Diagnostics (tsc)

main (08807ce) #5563 (2ffa48d) +/-
Files 83 83 0
Lines 59,446 59,458 +12
Identifiers 60,625 60,635 +10
Symbols 106,532 106,536 +4
Types 163,092 163,092 0
Instantiations 414,023 414,023 0
Memory used 157,377K 209,159K +51,782K
I/O read 0.01s 0.01s 0s
I/O write 0s 0s 0s
Parse time 0.19s 0.32s +0.13s
Bind time 0.07s 0.11s +0.04s
Check time 0.84s 1.49s +0.65s
Emit time 0s 0s 0s
Total time 1.1s 1.93s +0.83s

Compiler Diagnostics (typescript-go)

main (08807ce) #5563 (2ffa48d) +/-
Files 215 215 0
Lines 121,008 121,020 +12
Identifiers 107,353 107,363 +10
Symbols 181,164 181,168 +4
Types 262,348 262,348 0
Instantiations 621,588 621,588 0
Memory used 153,978K 153,997K +19K
Memory allocs 1,783,620 1,783,167 -453
Config time 0.001s 0.001s 0s
BuildInfo read time 0s 0.001s +0.001s
Parse time 0.056s 0.116s +0.06s
Bind time 0s 0s 0s
Check time 0.271s 0.503s +0.232s
Emit time 0.02s 0.005s -0.015s
Changes compute time 0.027s 0.036s +0.009s
Total time 0.396s 0.704s +0.308s

Reported by octocov

@github-actions

Copy link
Copy Markdown

HTTP Performance Benchmark

Framework Runtime Average Ping Query Body
hono (origin/main) bun 33,585.77 44,274.12 31,191.37 25,291.83
hono (current) bun 34,202.54 44,634.28 31,862.48 26,110.86
Change +1.84% +0.81% +2.15% +3.24%

@codecov

codecov Bot commented Oct 16, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.30%. Comparing base (08807ce) to head (9af970d).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5563   +/-   ##
=======================================
  Coverage   80.30%   80.30%           
=======================================
  Files         149      149           
  Lines       10516    10516           
  Branches     2351     2351           
=======================================
  Hits         8445     8445           
  Misses       2071     2071           

☔ View full report in Codecov by Harness.
ðŸ“Ē Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ïļ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ðŸ“Ķ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@usualoma

Copy link
Copy Markdown
Member

LGTM 👍

@yusukebe

Copy link
Copy Markdown
Member Author

@usualoma Thanks!

@yusukebe
yusukebe merged commit e9c0107 into main Oct 17, 2026
19 checks passed
@yusukebe
yusukebe deleted the fix/strict-false-excludes-get-path branch October 17, 2026 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants