Repository navigation
itemsync: Skip retries when removing already-absent files - #3697
Merged
Merged
Conversation
When removing items from a synced tab, each item's format files are deleted from disk. If a file was already gone, the remove call failed and was retried with 20ms sleeps between attempts, blocking the GUI thread. With many items this caused multi-second freezes. Treat remove as successful when the file no longer exists, avoiding pointless retries. Assisted-by: Claude (Anthropic)
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## master #3697 +/- ##
==========================================
- Coverage 74.52% 74.37% -0.15%
==========================================
Files 256 256
Lines 38010 38010
Branches 5122 5118 -4
==========================================
- Hits 28328 28271 -57
- Misses 9682 9739 +57 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When removing items from a synced tab, each item's format files are deleted from disk. If a file was already gone, the remove call failed and was retried with 20ms sleeps between attempts, blocking the GUI thread. With many items this caused multi-second freezes.
Treat remove as successful when the file no longer exists, avoiding pointless retries.
Assisted-by: Claude (Anthropic)