Skip to content

itemsync: Skip retries when removing already-absent files - #3697

Merged
hluk merged 1 commit into
masterfrom
fix-itemsync-remove-retry-delay
Sep 2, 2026
Merged

hluk merged 1 commit into
masterfrom
fix-itemsync-remove-retry-delay

Conversation

@hluk

@hluk hluk commented Sep 2, 2026

Copy link
Copy Markdown
Owner

When removing items from a synced tab, each item's format files are deleted from disk. If a file was already gone, the remove call failed and was retried with 20ms sleeps between attempts, blocking the GUI thread. With many items this caused multi-second freezes.

Treat remove as successful when the file no longer exists, avoiding pointless retries.

Assisted-by: Claude (Anthropic)

When removing items from a synced tab, each item's format files are
deleted from disk. If a file was already gone, the remove call failed
and was retried with 20ms sleeps between attempts, blocking the GUI
thread. With many items this caused multi-second freezes.

Treat remove as successful when the file no longer exists, avoiding
pointless retries.

Assisted-by: Claude (Anthropic)
@codecov

codecov Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 74.37%. Comparing base (0abed10) to head (596bcd3).

Files with missing lines Patch % Lines
plugins/itemsync/filewatcher.cpp 66.66% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (66.66%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3697      +/-   ##
==========================================
- Coverage   74.52%   74.37%   -0.15%     
==========================================
  Files         256      256              
  Lines       38010    38010              
  Branches     5122     5118       -4     
==========================================
- Hits        28328    28271      -57     
- Misses       9682     9739      +57     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hluk
hluk merged commit df0a192 into master Sep 2, 2026
12 of 15 checks passed
@hluk
hluk deleted the fix-itemsync-remove-retry-delay branch September 20, 2026 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant