Skip to content

Recover portal global shortcuts after session loss - #3680

Merged
hluk merged 1 commit into
masterfrom
fix-portal-shortcuts-recovery
Aug 15, 2026
Merged

hluk merged 1 commit into
masterfrom
fix-portal-shortcuts-recovery

Conversation

@hluk

@hluk hluk commented Aug 15, 2026 •

Copy link
Copy Markdown
Owner

Complements #3678 with mid-run recovery. Listens for the portal
Session::Closed signal and watches for portal service restarts so
shortcuts are automatically re-established after sleep/wake or
compositor restart.

Assisted-by: Claude (Anthropic)

@codecov

codecov Bot commented Aug 15, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.
✅ Project coverage is 74.53%. Comparing base (27fb6fc) to head (37d0d28).

Files with missing lines Patch % Lines
qxt/qxtglobalshortcut_x11.cpp 0.00% 35 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (80.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3680      +/-   ##
==========================================
- Coverage   74.58%   74.53%   -0.06%     
==========================================
  Files         256      256              
  Lines       37970    37993      +23     
  Branches     5119     5118       -1     
==========================================
- Hits        28321    28317       -4     
- Misses       9649     9676      +27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Listen for the portal Session::Closed signal and automatically
re-establish the session when it fires (e.g. after system sleep/wake
or compositor restart).

Keep the D-Bus service watcher active permanently so that portal
service restarts are detected and trigger reconnection, not just the
initial registration.

Guard against duplicate timer connections on reconnect with
Qt::UniqueConnection.

Assisted-by: Claude (Anthropic)
@hluk
hluk force-pushed the fix-portal-shortcuts-recovery branch from 135387c to 37d0d28 Compare August 15, 2026 08:02
@hluk hluk changed the title Fix portal global shortcuts not recovering after session loss Recover portal global shortcuts after session loss Aug 15, 2026
@hluk
hluk merged commit e0a3cb2 into master Aug 15, 2026
11 of 13 checks passed
@hluk
hluk deleted the fix-portal-shortcuts-recovery branch August 23, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant