Repository navigation
Fix version string in CI builds - #3504
Merged
Merged
Conversation
Codecov Reportâ
All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3504 +/- ##
=======================================
Coverage 80.86% 80.87%
=======================================
Files 245 245
Lines 31292 31294 +2
=======================================
+ Hits 25305 25308 +3
+ Misses 5987 5986 -1 â View full report in Codecov by Harness. ð New features to boost your workflow:
|
hluk
force-pushed
the
fix/ci-version-string
branch
from
March 26, 2026 11:46
1f4e589 to
16be251
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Updates CopyQâs build/version plumbing so CI produces a consistent, sortable version string derived from git describe, and ensures Windows installer metadata uses a numeric-only version.
Changes:
- Reworks CMake version generation to normalize
git describe --tagsoutput intoMajor.Minor.Patch[.N-gSHA], with a tag-ref fallback for limited CI clones. - Adds a CLI test assertion to validate the
versionStringformat. - Updates macOS/Windows GitHub Actions to fetch full history, extract the version from the generated build output via a new composite action, and pass a numeric version to Inno Setup.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
src/version.cmake |
Generates normalized/sortable version strings from git describe, with CI fallback. |
src/tests/tests_cli.cpp |
Adds test validation for the expected versionString format. |
shared/copyq.iss |
Switches installer VersionInfoVersion to a numeric-only value. |
.github/workflows/build-windows.yml |
Fetches full history, uses the new version extractor, and supplies numeric version to the installer build. |
.github/workflows/build-macos.yml |
Fetches full history and uses the new version extractor for bundle naming. |
.github/actions/get-version/action.yml |
New composite action to extract/validate the generated version string from the build directory. |
ðĄ Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Assisted-by: Claude (Anthropic)
hluk
force-pushed
the
fix/ci-version-string
branch
from
March 26, 2026 12:37
16be251 to
4e186ff
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assisted-by: Claude (Anthropic)