Skip to content

Fix version string in CI builds - #3504

Merged
hluk merged 1 commit into
masterfrom
fix/ci-version-string
Mar 26, 2026
Merged

hluk merged 1 commit into
masterfrom
fix/ci-version-string

Conversation

@hluk

@hluk hluk commented Mar 26, 2026

Copy link
Copy Markdown
Owner

Assisted-by: Claude (Anthropic)

@codecov

codecov Bot commented Mar 26, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 80.87%. Comparing base (1175475) to head (4e186ff).
⚠ïļ Report is 106 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3504   +/-   ##
=======================================
  Coverage   80.86%   80.87%           
=======================================
  Files         245      245           
  Lines       31292    31294    +2     
=======================================
+ Hits        25305    25308    +3     
+ Misses       5987     5986    -1     

☔ View full report in Codecov by Harness.
ðŸ“Ē Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄ïļ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • ðŸ“Ķ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hluk
hluk force-pushed the fix/ci-version-string branch from 1f4e589 to 16be251 Compare March 26, 2026 11:46
@hluk
hluk requested a review from Copilot March 26, 2026 11:46
Comment thread .github/actions/get-version/action.yml Fixed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates CopyQ’s build/version plumbing so CI produces a consistent, sortable version string derived from git describe, and ensures Windows installer metadata uses a numeric-only version.

Changes:

  • Reworks CMake version generation to normalize git describe --tags output into Major.Minor.Patch[.N-gSHA], with a tag-ref fallback for limited CI clones.
  • Adds a CLI test assertion to validate the versionString format.
  • Updates macOS/Windows GitHub Actions to fetch full history, extract the version from the generated build output via a new composite action, and pass a numeric version to Inno Setup.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
src/version.cmake Generates normalized/sortable version strings from git describe, with CI fallback.
src/tests/tests_cli.cpp Adds test validation for the expected versionString format.
shared/copyq.iss Switches installer VersionInfoVersion to a numeric-only value.
.github/workflows/build-windows.yml Fetches full history, uses the new version extractor, and supplies numeric version to the installer build.
.github/workflows/build-macos.yml Fetches full history and uses the new version extractor for bundle naming.
.github/actions/get-version/action.yml New composite action to extract/validate the generated version string from the build directory.

ðŸ’Ą Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread src/version.cmake
Comment thread shared/copyq.iss
Assisted-by: Claude (Anthropic)
@hluk
hluk force-pushed the fix/ci-version-string branch from 16be251 to 4e186ff Compare March 26, 2026 12:37
@hluk
hluk merged commit 4d1277b into master Mar 26, 2026
14 checks passed
@hluk
hluk deleted the fix/ci-version-string branch March 27, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants