Repository navigation
fix type signature of keepAlive - #375
Conversation
|
This function needs documentation. Does anyone have any wording in mind? |
|
Looks good, thanks. But while we're making one breaking change, I think I'll propose another, though they are arguably orthogonal. I should think that any user with a compiler older than GHC 9.0, for which this primitive did not exist, would not find a |
|
@mitchellwrosen, I believe the |
|
Oh, yes, thank you that makes sense. I'm not totally confident a sufficiently smart computer couldn't conclude that |
|
@mitchellwrosen It only has to trick sufficiently old versions of GHC, so we should be okay. |
|
I think this looks good. I'll merge this shortly unless there are any concerns about it. I've got something in mind for documentation, but it's going to include a lengthy description of lifted types, unlifted types, and types with identity, so I'll do that in its own PR and we can discuss there. |
|
Last thing I would add to this PR is that we should look into other outstanding PRs/TODOs if we're going to cut a major version release. |
|
This is wronger now. Too liberal! |
|
Unless you consider the primop type too conservative. Maybe it is? |
|
It actually almost certainly is. @chessai, do you think you could open a GHC proposal to make |
|
@chessai I'm not sure why you think the new type is too liberal. What type do you think would be right? |
|
@andrewthad That's what I thought for a few minutes, because it unsafely coerces the state token to work in contexts where the primop doesn't. But now I'm wondering if the primop is overly restrictive.... |
|
Really, there should be one decision for both the primop and this function. |
|
Sorry, I meant to address that last message to @treeowl I now understand that @treeowl is suggesting to match what GHC does. However, Here, I think that it's GHC that should change, not |
|
@treeowl and @chessai It is totally ok for In fact I've asked @bgamari to change the signature for
I guess he just probably forgot to do that. |
|
Okay, please consider my concern entirely retracted. We should be sure to remove the in unsafe correction once it becomes unnecessary. |
|
I have not been following the details here, but I'd love to get a thumbs-up from @bgamari . He has spend ages getting |
|
I've opened GHC Issue 23163 to discuss there. |
Addresses the issue discussed in the conversation starting with this comment.
cc @andrewthad @treeowl @mitchellwrosen for review
cc @bgamari for thoughts as well