Repository navigation
Fix deserialization of prefetches of external parameters - #9493
Merged
Merged
Conversation
deserialize_prefetch_directive only looked up the prefetched parameter in parameters_in_pipeline, but an ImageParam used by the pipeline is serialized as an external parameter, so deserializing a pipeline that prefetches an ImageParam failed with "unknown parameter used in pipeline". Look up user_params and external_params first, as the other parameter lookups do. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9493 +/- ##
==========================================
- Coverage 71.11% 71.08% -0.04%
==========================================
Files 261 261
Lines 80229 80233 +4
Branches 19551 19553 +2
==========================================
- Hits 57058 57033 -25
+ Misses 17374 17337 -37
- Partials 5797 5863 +66 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
alexreinking
approved these changes
Oct 1, 2026
Member
|
Real failure in |
Host-side prefetches can't be compiled for targets with the hvx feature (#9496). Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…deserialization # Conflicts: # test/correctness/serialization.cpp
Member
Author
|
Failure unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another fix PR discovered while working on halidoscope. AI text follows:
deserialize_prefetch_directive only looked up the prefetched parameter in parameters_in_pipeline, but an ImageParam used by the pipeline is serialized as an external parameter, so deserializing a pipeline that prefetches an ImageParam failed with "unknown parameter used in pipeline". Look up user_params and external_params first, as the other parameter lookups do.