Skip to content

[bug 680] Open up keybindings page on keypress #680 - #686

Merged
mattrose merged 1 commit into
gnome-terminator:masterfrom
vssdeo:680-open-up-keybindings-page-on-keypress
Nov 30, 2022
Merged

mattrose merged 1 commit into
gnome-terminator:masterfrom
vssdeo:680-open-up-keybindings-page-on-keypress

Conversation

@vssdeo

@vssdeo vssdeo commented Nov 23, 2022

Copy link
Copy Markdown
Contributor
  • implemented the short-cut
  • seems the key combo is already taken 'go_prev' : 'p'
  • How about : 'k', I will make the change for now.
  • But adding key seq to a long list of keypress function breaks my heart, If the plugin util keybind makes it to the main branch, I will take this out and may be have a shortcut plugin to handle these.
  • Also selecting of Keybindings page is being done for this specific case Page = 3
  • A notebook tab number and title map would remove this. Which can be configurable, later.

- implemented the short-cut
- seems the key combo is already taken 'go_prev' : 'p'
- How about : 'k', I will make the change for now.
- But adding key seq to a long list of keypress function breaks my heart, If the plugin util keybind makes it to the main branch, I will take this out and may be have a shortcut plugin to handle these.
- Also selecting of Keybindings page is being done for this specific case Page = 3
- A notebook tab number and title map would remove this. Which can be configurable, later.
@mattrose
mattrose merged commit 403bf54 into gnome-terminator:master Nov 30, 2022
@mattrose

Copy link
Copy Markdown
Member

Thank you!

@vssdeo

vssdeo commented Nov 30, 2022

Copy link
Copy Markdown
Contributor Author

Welcome !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants