Repository navigation
Cursor: make it possible to change foreground color (#467) - #486
Merged
Merged
Conversation
added 6 commits
August 13, 2021 17:27
Member
|
Working on another feature right now, but I'll take a look at this by monday hopefully |
Member
|
Wow, this was a lot more work than I thought it was. Great job, and thanks again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There were some changes to the GUI and to the config file.
Let's talk about the last one first.
Config
Currently, there are only two settings for the cursor colors:
cursor_colorandcursor_color_fg. Their names can easily confuse, becausecursor_coloris the background color, whilecursor_color_fgis a boolean (False = use a custom background; True = use the foreground as the background).I removed them both, and replaced them with three new settings:
cursor_fg_color,cursor_bg_colorandcursor_color_default. The first two are color strings, foreground and background. The last is a boolean (False = custom colors, True = default colors).Python code
Most of the changes are made to make the new GUI work.
I removed the old signal functions and the old logic that initializes the cursor colors in the preferences menu, replacing everything with the new code.
GUI
I changed the GUI related to the cursor, in the
Profiles > Globaltab.I also fixed some inconsistencies that I noticed in the whole menu:
Profiles > Titlebarthe Font selector was missing the "indentation"Profiles > Colorsis now just "Background"