hide_window mapped with Shift+Control+Alt+$an_alphabet catches Control+Alt+$an_alphabet instead #509

Activity

1. tomty89

   changed the title [-]Shift+Control+Alt+$an_alphabet mapped to hide_window catches Shift+Control+Alt+$an_alphabet instead[/-] [+]Shift+Control+Alt+$an_alphabet mapped to hide_window catches Control+Alt+$an_alphabet instead[/+] on Sep 10, 2021
2. tomty89

   changed the title [-]Shift+Control+Alt+$an_alphabet mapped to hide_window catches Control+Alt+$an_alphabet instead[/-] [+]hide_window mapped with Shift+Control+Alt+$an_alphabet catches Control+Alt+$an_alphabet instead[/+] on Sep 10, 2021
3. Vulcalien commented on Sep 10, 2021

   

   Vulcalien

   on Sep 10, 2021

   Last edited by Vulcalien

   Member

   More actions

   Relevant code: (window.py, line 135)

   self.hidebound = Keybinder.bind(
       self.config['keybindings']['hide_window'].replace('<Shift>',''),
       self.on_hide_window)

   I experience this too, on GNOME (Debian)
4. tomty89 commented on Sep 10, 2021

   

   tomty89

   on Sep 10, 2021

   ContributorAuthor

   More actions

   @sboddy Could you provide any details about the commit?
5. Vulcalien commented on Sep 10, 2021

   

   Vulcalien

   on Sep 10, 2021

   Member

   More actions

   I don't think they work on Terminator anymore, that commit is 5 years old. It's supposed to fix the shift keys, I guess. However, if I remove the replace, it won't work at all. It might be an outdated library, or something has changed in these years.
6. tomty89 commented on Sep 10, 2021

   

   tomty89

   on Sep 10, 2021

   Last edited by tomty89

   ContributorAuthor

   More actions

   It's odd that it's only a problem with hide_window though. Anyway, I guess we can/should at least change the default of hide_window to something else (e.g. Ctrl+Alt+H?) unless someone has a better fix. To be honest, this replace fix hardly makes senses anyway (it's literally worse than a FIXME comment...).
7. Vulcalien commented on Sep 10, 2021

   

   Vulcalien

   on Sep 10, 2021

   Last edited by Vulcalien

   Member

   More actions

   I agree, the default should be different if we don't manage to fix this. hide_window is binded in an different way than all the other keybindings: it's a system-wide bind, because when the window is hidden, it must catch the keys even without focus. I'm reading the documentation, maybe I can see what we are doing wrong.

   Edit: however the behavior is not the same on every system, I think.
8. Vulcalien commented on Sep 11, 2021

   

   Vulcalien

   on Sep 11, 2021

   Member

   More actions

   The best documentation I found is the comments in the code. They are pretty good.

   From this:

   "Cooked" accelerators use symbols produced by using modifiers such as shift or altgr, for example if "!" is produced by "Shift+1".

   keybinder_set_use_cooked_accelerators

   This seems connected to our problem.
9. Vulcalien commented on Sep 11, 2021

   

   Vulcalien

   on Sep 11, 2021

   Member

   More actions

   I made a patch to fix the issue. It should work as expected now, thanks for reporting the problem!
10. mattrose

    closed this as completedin #510on Sep 11, 2021
11. awvalenti commented on Mar 1, 2024

    

    awvalenti

    on Mar 1, 2024

    More actions

    Hello. I just experienced this issue again:

    Terminator was capturing my Ctrl Alt A usage from another app and executing hide_window, which was by default mapped to Ctrl Shift Alt A.

    Ctrl Alt A was mapped by default to edit_tab_title.

    I simply disabled both shortcuts for now.