Repository navigation
Black background remains after hide_window #425
Description
Describe the bug
When I use hide_window, a black background remains. If the terminal was maximized at the time I used hide_window, this black background also remains maximized, hidding the entiere desktop.
To Reproduce
Sometimes it happens without reasons (known reasons at least).
I found a way to reproduce it all the time (on my system):
- Start Terminator (
hide_windowworks well) - Start a new instance, so there is now two Terminator (
hide_windowstill works well) - Close one of the instance (the problems starts here)
The screenshots below will nicely help understand the problem.
Expected behavior
hide_window should not let this black background (and the worst of all, always on top).
Screenshots
-
I just started one Terminator
-
The second one is also started
-
I closed one of them (it's not important if it's the first I opened of the second, it doesn't change the bug)
-
Now when I use
hide_windowI have this little black square remaining.
As you can see, a tiny black square is no big deal. The big problem is when the terminal was maximized.
Here is what happens:
-
Terminator maximized
-
Hidden !
Normally I have a black background and no window title. This combo made me crazy as I didn't understand at the first glance that the background was Terminator, I though all my other windows where disappearing...
The steps above are one way I could reproduce the bug, but it does appear even without doing this. One minute it's ok and the other, a black background appears. As I do a lot of hide_window through the day, it is very annoying :(
Desktop (please complete the following information):
- Kali Linux 2021.1, XFCE
Additional context
For some unknown reasons, the default shortcut for hide_window didn't work so I changed it (all keys I tried produce the same bug).
Activity
Darkproduct commentedon Apr 21, 2021
I have experienced this issue too. I use terminator always in full-screen-mode and just hide the window if necessary. When I open a new terminator window by accident, then my
hide_windowkey will just switch between the two instances. Hide one and open the other. After closing one instance, the focus will be messed up. (You can't select something with your mouse, and so on.)This will be fixed after closing both instances and opening only one again. Its a bit annoying, but my take away was: just do not open to terminators, with splits it is not even necessary. And yes, that's not a good take away.
mattrose commentedon Apr 22, 2021
hmm, I'm just calling window.hide(), or window.iconify() here, so that leads me to believe that GTK is doing something wrong, but I could be wrong. Can you reproduce the problem with
terminator -dand attach the logs. And I'll try reproducing it on my desktop@toyi can you tell me what linux distro and version you're using?
Thanks @Darkproduct for confirming this works for you because now I know it'll work on GNOME.
toyi commentedon Apr 23, 2021
I'm on Kali 2021.1 with XFCE.
This is the (pretty long) log I got with
terminator -d. I did all the steps described in the issue, exactly as I did with the screenshots. The bug starts to appear when I close the second terminator, in the second half of the log, atTerminator::deregister_terminal.Honnestly even if I'm was pretty sure I did encounter this bug without opening two Terminator, I'm starting to doubt a little bit: I didn't have any problem since I keep paying attention to NOT open two Terminator at once. I could have done that by mistake, I really don't know. Anyway, it's still "not a good take away" to quote @Darkproduct.
I wish I could help more but I'm not familiar with Python (althrough I would love to dig in, but sadly a day only last 24h you know :/).
debugdump.txt
edited by @mattrose to put the debug into a file
Darkproduct commentedon Apr 23, 2021
Here are the logs from Gnome 3.36.8 with Ubuntu 20.04.2 LTS.
Open one terminator and hide it
Open a second terminator and pressing the `hide_window`-key (Insert) 4 times before closing it
Meanwhile the log from the terminator 1
Pressing `hide_window` once again, to get to the first terminator, click with the mouse 3 times on the window and hide it again
After clicking with the mouse the terminator window is not focused and I can't type anything. I need to hide and unhide it again to get the focus fixed. Now I can use it normally until I use my mouse for anything again. Like copying something.
For completness, here is the end.
Pressing the `hide_window`-Key to get to the terminator and pressing `Strg + d`
mattrose commentedon Apr 23, 2021
Hmm, this is what it looks like for me
and I get this when I click in that space:
(terminator:597002): Gtk-CRITICAL **: 15:20:11.256: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.256: gtk_widget_translate_coordinates: assertion 'GTK_IS_WIDGET (dest_widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.256: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.257: gtk_widget_translate_coordinates: assertion 'GTK_IS_WIDGET (dest_widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.257: gtk_widget_get_settings: assertion 'GTK_IS_WIDGET (widget)' failed
/usr/lib/python3/dist-packages/gi/overrides/Gtk.py:1649: Warning: g_object_get: assertion 'G_IS_OBJECT (object)' failed
return _Gtk_main(*args, **kwargs)
(terminator:597002): Gtk-CRITICAL **: 15:20:11.257: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.257: gtk_widget_translate_coordinates: assertion 'GTK_IS_WIDGET (dest_widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.390: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.390: gtk_widget_translate_coordinates: assertion 'GTK_IS_WIDGET (dest_widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.390: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed
(terminator:597002): Gtk-CRITICAL **: 15:20:11.390: gtk_widget_get_window: assertion 'GTK_IS_WIDGET (widget)' failed
Fixed issue gnome-terminator#425 (hide_window will try to show destroâĶ
Fixed Issue gnome-terminator#425 (hide_window will try to show a destâĶ
Merge pull request #456 from Vulcalien/master
mattrose commentedon Jul 5, 2021
Confirmed @Vulcalien pr #456 fixes this
skaryzgik commentedon Jul 10, 2022
I am also having this issue. I see that it has been "fixed" over a year ago, but it clearly is still happening, even after I added the PPA to get the newest version (terminator 2.1.1; Ubuntu 20.4; GNOME Shell 3.36.9).
I observe that the commit where this was fixed, despite being a year ago, is still newer than the newest Release. Is there planned to be a new Release soon that includes this fix, or will I need to build the "bleeding edge" from master (and then have to manually check myself for updates for this individual package, rather than allowing a package manager to check for me and remind me when there are updates)?
mattrose commentedon Jul 11, 2022
Hopefully this month. I've been wanting to do a release for a while, but I just haven't had the time.