Repository navigation
Custom color palette not being memorized #129
Description
This is an easily reproducible bug, click preferences, profiles, colors, configure custom color palette. I like colors from manjaro distro on my arch. Then close everything. Next time you visit same location in preferences, you will see that your color scheme will be Linux, instead of custom.
However, if you select custom again, without configuring each color, you will have your colors that you configured earlier.
In any case, this is an annoying bug and bugs me cuz every time I have to go into preferences and configure something, I have to change the platte to custom in order to have my colors.
Activity
mattrose commentedon Jun 17, 2020
Looked into this a bit. The prefs pane appears to save the palette in
.config/terminator/configjust fine. I think the problem is that the preference pane doesn't ever reload the new config file until you restart. Can you try reproducing the problem, except, after you close everything, make sure there are no terminator instances running?dugb commentedon Jul 8, 2020
I think what is going on here is that a users 'custom palette' is not saved in .config/terminator/config as a custom-palette. It is saved as
palette.So if a user sets up all their colors for a custom palette, that palette is saved as
palette.But then if they decide to try out Tango palette the Tango palette is saved as
paletteand overwrites all their custom colors.Then if the user decided they don't want to use Tango palette anymore and they want to go back to using the custom palette they setup, all their custom colors are gone.
I recommend continue saving the current palette as
palettein the config and addingcustom-paletteto save the users custom colors.I'll look into make changes.
mattrose commentedon Jul 9, 2020
@SCCOBN PR #160 appears to fix this, can you confirm?