Repository navigation
Unit test fails on python 3.14 #1089
Description
Describe the bug
unit test fails on py3.14
FAILED tests/test_prefseditor_keybindings.py::test_duplicate_accels_not_possible_to_set[accel_params0] - assert (97, <flags GDK_CONTROL_MASK | GDK_MOD1_MASK of type Gdk.ModifierType>) in {(accelerator_key=43, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (accelerator_key=45, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (accel...
FAILED tests/test_prefseditor_keybindings.py::test_duplicate_accels_not_possible_to_set[accel_params1] - assert (97, <flags GDK_CONTROL_MASK | GDK_MOD1_MASK of type Gdk.ModifierType>) in {(accelerator_key=43, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (accelerator_key=45, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (accel...
FAILED tests/test_prefseditor_keybindings.py::test_duplicate_accels_not_possible_to_set[accel_params2] - assert (65480, <flags 0 of type Gdk.ModifierType>) in {(accelerator_key=43, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (accelerator_key=45, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (accelerator_key=65289, accelerato...
FAILED tests/test_prefseditor_keybindings.py::test_duplicate_accels_not_possible_to_set[accel_params3] - assert (122, <flags GDK_SHIFT_MASK | GDK_CONTROL_MASK of type Gdk.ModifierType>) in {(accelerator_key=43, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (accelerator_key=45, accelerator_mods=<flags GDK_CONTROL_MASK of type Gdk.ModifierType>), (acc...
To Reproduce
pytest in terminator's source
Expected behavior
test should pass
Screenshots
If applicable, add screenshots to help explain your problem.
Desktop (please complete the following information):
- OS or Linux Distribution: [e.g. FreeBSD or Ubuntu] Gentoo linux, amd64
- Version [e.g. 20.04]
- Display Technology: X11
Additional context
Add any other context about the problem here.
log: build.txt
Activity
mattrose commentedon May 21, 2026
Funny, the ci tests are run on ubuntu and they work fine. On my fedora 42 desktop and on my macos desktop the same test works fine.
terminator: fix test failure with gi.ResultTuple hash mismatch
blshkv commentedon Jun 3, 2026
I'm not sure why it is funny. Your setup is unable to detect a broken code giving you a false positive result. You should look up and fix it.
mattrose commentedon Jun 3, 2026
I meant funny as in odd, or unusual, as I was unable to reproduce the problem with the information given in the issue. I also have tested it on multiple platforms using python 3.14 and the same tests pass.
mattrose commentedon Jun 3, 2026
Good news. Was able to reproduce on Fedora 44
tests: fix accelerator_parse hash mismatch on Python 3.14
blshkv commentedon Jun 3, 2026
Great, thanks. So did you manage to figure out what was the difference in the set-up of different OS you tried?
mattrose commentedon Jun 4, 2026
Upgrading from Fedora 42 to Fedora 44. I suspect it was a change in the GTK lib, or the python bindings for it.