Repository navigation
[dead-code] chore: remove dead functions — 2 functions removed - #71916
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
The removed functions have no remaining repository references, active implementations remain intact, and equivalent scanner regression coverage is retained.
No open issues 🎉
What changed in this PR
Removes three unused functions from gh-aw’s compiler, taint analysis, and scanner code while preserving the active implementations.
Changes:
- Removes
Compiler.CompileDocument,actionlintShellcheckIdentity, andAnalyzeAuthoredJavaScript. - Removes obsolete tests and updates remaining scanner tests to call
shellcheckIdentitydirectly. - Updates documentation comments that referenced
CompileDocument.
| File | Description |
|---|---|
pkg/workflow/taint/workflow.go |
Updates the compiler reference in a documentation comment. |
pkg/workflow/taint/authored.go |
Removes the unused exported JavaScript analysis wrapper. |
pkg/workflow/compiler_document.go |
Removes CompileDocument and its unused import. |
pkg/workflow/compiler_document_test.go |
Removes tests specific to CompileDocument and unused imports. |
pkg/workflow/aw/doc.go |
Updates package documentation to describe the remaining compilation path. |
pkg/cli/compile_scanner_differential.go |
Removes the unused shellcheck identity wrapper. |
pkg/cli/compile_scanner_differential_test.go |
Uses the underlying method directly and removes redundant regression coverage. |
Review effort: Max
|
🎉 This pull request is included in a new release. Release: |
Functions Removed
Compiler.CompileDocumentpkg/workflow/compiler_document.goactionlintShellcheckIdentitypkg/cli/compile_scanner_differential.goAnalyzeAuthoredJavaScriptpkg/workflow/taint/authored.go(Three functions removed; title count corrected here.) Doc comments referencing
CompileDocumentwere updated.Tests Removed
TestCompileDocumentToActionsAST,TestCompileDocumentValidationErrors,TestCompileDocumentPropagatesCompilationFailuresTestActionlintShellcheckIdentitySurvivesLeadingScriptCommentactionlintShellcheckIdentitynow callmake(scannerSources).shellcheckIdentitydirectly.Verification
go build ./...go vet ./...go vet -tags=integration(pkg/workflow, pkg/cli)TestVerifyGitCredentials*(pkg/workflow) andTestRenderScheduleCalendarCell_UsesANSIInColorTerminal(pkg/cli) fail on main too; unrelated.https://github.com/github/gh-aw/actions/runs/40201575786