Skip to content

[dead-code] chore: remove dead functions — 2 functions removed - #71916

Merged
pelikhan merged 1 commit into
mainfrom
chore/remove-dead-functions-40201575786-da4f7db51c641c94
Oct 25, 2026
Merged

pelikhan merged 1 commit into
mainfrom
chore/remove-dead-functions-40201575786-da4f7db51c641c94

Conversation

@github-actions

Copy link
Copy Markdown
Contributor

Functions Removed

Function File
Compiler.CompileDocument pkg/workflow/compiler_document.go
actionlintShellcheckIdentity pkg/cli/compile_scanner_differential.go
AnalyzeAuthoredJavaScript pkg/workflow/taint/authored.go

(Three functions removed; title count corrected here.) Doc comments referencing CompileDocument were updated.

Tests Removed

  • TestCompileDocumentToActionsAST, TestCompileDocumentValidationErrors, TestCompileDocumentPropagatesCompilationFailures
  • TestActionlintShellcheckIdentitySurvivesLeadingScriptComment
  • Remaining tests calling actionlintShellcheckIdentity now call make(scannerSources).shellcheckIdentity directly.

Verification

  • go build ./...
  • go vet ./...
  • go vet -tags=integration (pkg/workflow, pkg/cli)
  • gofmt on edited files
  • Note: TestVerifyGitCredentials* (pkg/workflow) and TestRenderScheduleCalendarCell_UsesANSIInColorTerminal (pkg/cli) fail on main too; unrelated.

https://github.com/github/gh-aw/actions/runs/40201575786

Generated by 🧹 Dead Code Removal Agent · copilot · auto · ~80 AIC · ⌖ ~1 AIC · ⊞ 10.2K · ◷

  • expires on Oct 28, 2026, 6:40 AM UTC-08:00

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 25, 2026 16:53
Copilot AI max review requested due to automatic review settings October 25, 2026 16:53
@pelikhan
pelikhan merged commit f42ab1f into main Oct 25, 2026
2 checks passed
@pelikhan
pelikhan deleted the chore/remove-dead-functions-40201575786-da4f7db51c641c94 branch October 25, 2026 16:54
@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~6 AIC · ⌖ ~6 AIC · ⊞ 14.8K · ◷

Generated by Ponytail Reviewer for #71916

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · ~12 AIC · ⌖ ~32 AIC · ◇ ~3 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Oct 25, 2026 •

Copy link
Copy Markdown
Contributor Author

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · sonnet50 · ~15 AIC · ⌖ ~15 AIC · ◇ ~7 AIC · ⊞ 12.7K · ◷

🧪 Test quality analysis by Test Quality Sentinel

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The removed functions have no remaining repository references, active implementations remain intact, and equivalent scanner regression coverage is retained.

No open issues 🎉

What changed in this PR

Removes three unused functions from gh-aw’s compiler, taint analysis, and scanner code while preserving the active implementations.

Changes:

  • Removes Compiler.CompileDocument, actionlintShellcheckIdentity, and AnalyzeAuthoredJavaScript.
  • Removes obsolete tests and updates remaining scanner tests to call shellcheckIdentity directly.
  • Updates documentation comments that referenced CompileDocument.
File Description
pkg/​workflow/​taint/​workflow.go Updates the compiler reference in a documentation comment.
pkg/​workflow/​taint/​authored.go Removes the unused exported JavaScript analysis wrapper.
pkg/​workflow/​compiler_document.go Removes CompileDocument and its unused import.
pkg/​workflow/​compiler_document_test.go Removes tests specific to CompileDocument and unused imports.
pkg/​workflow/​aw/​doc.go Updates package documentation to describe the remaining compilation path.
pkg/​cli/​compile_scanner_differential.go Removes the unused shellcheck identity wrapper.
pkg/​cli/​compile_scanner_differential_test.go Uses the underlying method directly and removes redundant regression coverage.

Review effort: Max

@github-actions

Copy link
Copy Markdown
Contributor Author

🎉 This pull request is included in a new release.

Release: v0.93.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants