Repository navigation
Fix missing grader runtime error codes dependency - #71689
Conversation
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
✅ PR Code Quality Reviewer completed the code quality review.
|
|
✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft. Design Decision Gate 🏗️Outcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
✅ Test Quality Sentinel completed test quality analysis. Test Quality SentinelOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
|
🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅
|
|
✅ Ponytail Reviewer completed successfully! Ponytail ReviewerOutcome: The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible. Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.
|
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped fix supplies the required dependency and adds targeted regression coverage, with no unresolved issues identified.
No open issues 🎉
What changed in this PR
Fixes grader replay in gh-aw by including a required dependency in the staged runtime.
Changes:
- Stages the already-embedded
error_codes.cjsalongside the grader modules. - Adds regression coverage for module loading from an unrelated working directory, with an empty environment and Node.js filesystem permissions enabled.
| File | Description |
|---|---|
pkg/cli/graders_run.go |
Includes the missing dependency in runtime staging. |
pkg/cli/graders_run_test.go |
Adds an isolated runtime dependency-loading test. |
Review effort: Max
|
🎉 This pull request is included in a new release. Release: |
Summary
Built-in, custom JavaScript, and operational-value grader replay fail with
Cannot find module './error_codes.cjs'because the CLI's staged runtime omits a dependency now required bygrader_session.cjs.Stage the already-embedded
error_codes.cjsalongside the grader modules. Add a regression test that loads the staged modules from an unrelated working directory with an empty environment and Node.js filesystem permissions enabled.Validation
TestStageGraderRuntimeLoadsDependenciespass withCGO_ENABLED=1.make build,make fmt, andmake agent-report-progresspass.