Skip to content

Fix missing grader runtime error codes dependency - #71689

Merged
pelikhan merged 1 commit into
mainfrom
pelikhan-ubiquitous-potato
Oct 24, 2026
Merged

pelikhan merged 1 commit into
mainfrom
pelikhan-ubiquitous-potato

Conversation

@pelikhan

Copy link
Copy Markdown
Collaborator

Summary

Built-in, custom JavaScript, and operational-value grader replay fail with Cannot find module './error_codes.cjs' because the CLI's staged runtime omits a dependency now required by grader_session.cjs.

Stage the already-embedded error_codes.cjs alongside the grader modules. Add a regression test that loads the staged modules from an unrelated working directory with an empty environment and Node.js filesystem permissions enabled.

Validation

  • Reproduced all four reported grader failures before the fix.
  • All four original tests and TestStageGraderRuntimeLoadsDependencies pass with CGO_ENABLED=1.
  • Focused grader tests, make build, make fmt, and make agent-report-progress pass.
  • Full workflow drift check compiled 348 workflows successfully with no lock-file changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@pelikhan
pelikhan marked this pull request as ready for review October 24, 2026 18:29
Copilot AI max review requested due to automatic review settings October 24, 2026 18:29
@pelikhan
pelikhan merged commit d861c8e into main Oct 24, 2026
35 of 47 checks passed
@pelikhan
pelikhan deleted the pelikhan-ubiquitous-potato branch October 24, 2026 18:30
@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

✅ PR Code Quality Reviewer completed the code quality review.

🔎 Code quality review by PR Code Quality Reviewer

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

✅ Design Decision Gate 🏗️ completed the design decision gate check. See the comment below for the result and any generated ADR draft.

Design Decision Gate 🏗️

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Design Decision Gate 🏗️ · opus55 · ~12 AIC · ⌖ ~37 AIC · ◇ ~16 AIC · ⊞ 1.9K · ◷

🏗️ ADR gate enforced by Design Decision Gate 🏗️

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

✅ Test Quality Sentinel completed test quality analysis.

Test Quality Sentinel

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Test Quality Sentinel · sonnet50 · ~14 AIC · ⌖ ~16 AIC · ◇ ~7 AIC · ⊞ 12.6K · ◷

🧪 Test quality analysis by Test Quality Sentinel

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

🧠 Matt Pocock Skills Reviewer has completed the skills-based review. ✅

🧠 Reviewed using Matt Pocock's skills by Matt Pocock Skills Reviewer

@github-actions

github-actions Bot commented Oct 24, 2026 •

Copy link
Copy Markdown
Contributor

✅ Ponytail Reviewer completed successfully!

Ponytail Reviewer

Outcome: reported_no_action

The agent completed and reported no action. A no-op output alone does not verify that all required work was completed or that publication was possible.

Agent messages are omitted from this comment. The category uses structured run status, not interpretation of agent prose.

Generated from Ponytail Reviewer · gpt56 · ~6 AIC · ⌖ ~6 AIC · ⊞ 14.8K · ◷

Generated by Ponytail Reviewer for #71689

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The narrowly scoped fix supplies the required dependency and adds targeted regression coverage, with no unresolved issues identified.

No open issues 🎉

What changed in this PR

Fixes grader replay in gh-aw by including a required dependency in the staged runtime.

Changes:

  • Stages the already-embedded error_codes.cjs alongside the grader modules.
  • Adds regression coverage for module loading from an unrelated working directory, with an empty environment and Node.js filesystem permissions enabled.
File Description
pkg/​cli/​graders_run.go Includes the missing dependency in runtime staging.
pkg/​cli/​graders_run_test.go Adds an isolated runtime dependency-loading test.

Review effort: Max

@github-actions

Copy link
Copy Markdown
Contributor

🎉 This pull request is included in a new release.

Release: v0.93.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants